Fix landing admin option typing and theme demo title - #113
Merged
Conversation
Co-authored-by: thinkdj <688055+thinkdj@users.noreply.github.com>
Author
|
Just as a heads up, I was blocked by some firewall rules while working on your feedback. Expand below for details. Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
Copilot
AI
changed the title
[WIP] Refactor homepage and theme preview functionality
Fix landing admin option typing and theme demo title
Feb 19, 2026
thinkdj
approved these changes
Feb 19, 2026
There was a problem hiding this comment.
Pull request overview
This PR fixes TypeScript type-checking errors in the Next.js landing app by correcting select option typing in OttaORM models and fixing a theme demo page reference.
Changes:
- Added required
idandnamefields to select options in landing section form configurations to satisfyModelFieldstyping requirements - Fixed theme demo page to reference
config.theme.nameinstead of non-existentconfig.themeBase - Updated Next.js 16 auto-generated type import path in next-env.d.ts
Reviewed changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| packages/ottalanding/src/section-fields.ts | Added id and name fields to select options for features columns, pricing billing, and feature highlight image position |
| packages/ottalanding/src/ottaorm-models/LandingSection.ts | Added id and name fields to section type select options |
| apps/ottabase-template-app-nextjs-homepage/app/theme-demo/page.tsx | Changed title from config.themeBase to config.theme.name to reference correct property |
| apps/ottabase-template-app-nextjs-homepage/next-env.d.ts | Updated Next.js 16 auto-generated type import path from .next/types to .next/dev/types |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Next.js landing app type-check failed: the theme demo referenced a non-existent
themeBase, and landing admin select options lacked required fields forModelFields.namein/theme-demoto avoid undefined config access.id/nameto section select option objects so landing section forms satisfyModelFieldstyping.Example:
https://github.com/user-attachments/assets/ff28d4fc-08a5-47d9-aa03-e5364a50e9ef
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.