Include Repeat Templates in upcoming(), fixes #122#145
Closed
bkleinen wants to merge 15 commits intothingsapi:mainfrom
Closed
Include Repeat Templates in upcoming(), fixes #122#145bkleinen wants to merge 15 commits intothingsapi:mainfrom
bkleinen wants to merge 15 commits intothingsapi:mainfrom
Conversation
…ng datetime(now) to sqlite (testability)
…nstance from the repeat template
|
Contributor
Author
|
Having slept over this, I realized that I would like / it needs a third option for the parameter, so not only this: but also this: because I would want to be able to ask for tomorrow's tasks with the repeats. As my branch name was incorrect anyways I close this PR and will open a new one (or re-open this one, if you prefer?) when done. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Done. I've decided to do two seperate requests from the api to the database, as upcoming = startdate > today and start=2 has nothing to do with "having a repeat template". the templates store a next instance start date, which I don't use, as they are always in the future.
I've extracted some of the date query logic in order to provide a fixed date for "today" from the tests.
I've added two tests that show the (imho incorrect) behaviour on cancelled/completed tasks: test_upcoming_includes_completed_and_canceled
this is because the test data has a incorrect start value:
test_upcoming_includes_repeating_instance