Add creation date as parameter, allow both dates and offsets as values, proof of concept for #142#143
Closed
bkleinen wants to merge 8 commits intothingsapi:mainfrom
Closed
Conversation
|
Contributor
|
If you want to add |
Contributor
|
@bkleinen Checking in if you're still around. |
Contributor
|
Closing for now since no response. Happy to open back up once you return. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Here's my proof of concept for issue #142, introducing both a creation date parameter "created_at" and the option (just for this parameter for now) to have both offsets and dates as values.
This implementation is a proof of concept, I've implemented it without changing any other methods.
If you like the idea to have both kinds of values for all date parameter, some refactoring should be done.