Repository navigation
fix(aux-window): make the tool window behave as the modal it says it is - #138
Merged
Merged
Conversation
- Canvas shortcuts stop at the window: Delete removed selected states from behind the Library, and S/T/V/D, Shift+X, Enter and the arrows reached the hidden canvas. Only the window's own keys and save/reopen get through. - The focus trap counts Tab stops only, so Shift+Tab no longer walks out past the roving-tabindex tabs; a collapsed phone sheet is not a stop either. - Escape from a field inside the window closes it, after any popover or non-empty search box has had the key. - showStatus writes to the window's own toast while it is open; the canvas toast was underneath it. - The symbol-suggest popover sits above the window and the modals (1100). - On a phone the window sits under the header (195 < 200), so the menus the header drops are no longer covered. - Phone Grammar loses its doubled padding and left-aligns its actions; the Library rail gets the top inset the other rails have.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The window Library, Algorithms, Grammar and Reference share is
aria-modal, but several things reached through it or hid behind it. Each was reproduced in headless Chromium before the fix and checked there after.Behaviour
auxWindowKeyinui.jsnow lets through only the window's own keys (Escape, view digits, the UTM simulator's keys in Algorithms) plus save and reopen-closed-tab.tabindex=-1) as first and last. It now counts Tab stops only, and skips a collapsed phone sheet (visibility: hidden).showStatuswrote to the canvas toast under the window; while the window is open it writes to a new#aux-status.Layering
.sym-suggestraised from 800 to 1100. It completes fields in the Algorithms and Grammar views and in the transition dialog's multi-tape Write fields, and was drawn under both the window (890) and modals (900).Visual
Tests: four new cases in
tests/aux-window.test.js: keys stop at the window, Escape from a field, the in-window toast, and the z-index relationships. Full suite: 2819 pass.npm run buildsucceeds.