fix react-ui invalid chart geometry - #986
Draft
vishxrad wants to merge 1 commit into
Draft
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
vishxrad
marked this pull request as ready for review
August 14, 2026 13:55
vishxrad
marked this pull request as draft
August 14, 2026 13:55
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Root cause
Recharts can briefly provide NaN dimensions while measuring a responsive bar chart, including charts in containers that have not finished layout. LineInBarShape used those values as SVG path and line coordinates, producing invalid DOM attributes and React warnings.
The custom shape now validates all DOM-bound geometry at its render boundary and returns null only for the invalid pass. It remains stateless and renders normally when Recharts provides finite geometry.
Validation
Extracted from #985 to keep the assistant-ui package change focused.