module: cadence: keep ipc3 on the raw-data path to fix compressed playback - #11144
Open
dbaluta wants to merge 1 commit into
Open
module: cadence: keep ipc3 on the raw-data path to fix compressed playback#11144dbaluta wants to merge 1 commit into
dbaluta wants to merge 1 commit into
Conversation
…yback Partially revert 0b94fe7 for the IPC3 variant only. Moving cadence IPC3 to the sink/source .process interface broke compressed playback a decoded codec frame is far larger than the LL sink can hold, so output never fits and is never committed. The raw-data path uses the adapter's intermediate buffer, which absorbs the frame. IPC4 and the shared helpers from that commit are kept. Fixes: 0b94fe7 ("module: cadence: rework module to use sink/source api") Signed-off-by: Daniel Baluta <daniel.baluta@nxp.com> Assisted-by: Claude Opus 4.8
dbaluta
requested review from
kv2019i,
lbetlej,
lgirdwood,
mmaka1 and
plbossart
as code owners
August 31, 2026 15:21
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adjusts the IPC3 Cadence codec module to use the module-adapter raw-data processing path again, restoring compressed playback by routing decoded frames through the adapter’s intermediate buffering rather than directly through the sink/source .process interface.
Changes:
- Switch IPC3 Cadence processing from sink/source
.processto.process_raw_datato re-enable the raw-data buffering path. - Update the IPC3 processing function to consume/produce via
input_stream_buffer/output_stream_bufferinstead of sink/source APIs.
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
221
to
+225
| struct module_data *codec = &mod->priv; | ||
| size_t output_bytes = cadence_codec_get_samples(mod) * | ||
| int free_bytes, output_bytes = cadence_codec_get_samples(mod) * | ||
| mod->stream_params->sample_container_bytes * | ||
| mod->stream_params->channels; | ||
| size_t remaining = source_get_data_available(sources[0]); | ||
| const void *source_buffer_start, *src_ptr; | ||
| void *sink_ptr, *sink_buffer_start; | ||
| size_t src_bytes, sink_bytes; | ||
| uint32_t remaining = input_buffers[0].size; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Partially revert 0b94fe7 for the IPC3 variant only. Moving cadence IPC3 to the sink/source .process interface broke compressed playback a decoded codec frame is far larger than the LL sink can hold, so output never fits and is never committed. The raw-data path uses the adapter's intermediate buffer, which absorbs the frame. IPC4 and the shared helpers from that commit are kept.
Fixes: 0b94fe7 ("module: cadence: rework module to use sink/source api")