Audio: Fix the init() in modules to not initialize bytes control with invalid data#10646
Draft
singalsu wants to merge 8 commits intothesofproject:mainfrom
Draft
Audio: Fix the init() in modules to not initialize bytes control with invalid data#10646singalsu wants to merge 8 commits intothesofproject:mainfrom
singalsu wants to merge 8 commits intothesofproject:mainfrom
Conversation
The pass of bytes control in init() was used in some very early IPC3 kernels. With IPC4 the module configuration data is not for control. If a topology does not contain a blob to initialize the control, the comp_init_data_blob() call initializes to blob handler an invalid blob that is attempted to be used in prepare(). The prepare() then fails with invalid blob detected while it should result to pass-through mode. A check is also added to prepare() for the data_size from comp_get_data_blob(). Signed-off-by: Seppo Ingalsuo <seppo.ingalsuo@linux.intel.com>
The pass of bytes control in init() was used in some very early IPC3 kernels. With IPC4 the module configuration data is not for control. If a topology does not contain a blob to initialize the control, the comp_init_data_blob() call initializes to blob handler an invalid blob that is attempted to be used in prepare(). The prepare() then fails with invalid blob detected while it should result to pass-through mode. A check is also added to prepare() for the data_size from comp_get_data_blob(). Signed-off-by: Seppo Ingalsuo <seppo.ingalsuo@linux.intel.com>
Signed-off-by: Seppo Ingalsuo <seppo.ingalsuo@linux.intel.com>
Signed-off-by: Seppo Ingalsuo <seppo.ingalsuo@linux.intel.com>
Signed-off-by: Seppo Ingalsuo <seppo.ingalsuo@linux.intel.com>
Signed-off-by: Seppo Ingalsuo <seppo.ingalsuo@linux.intel.com>
Signed-off-by: Seppo Ingalsuo <seppo.ingalsuo@linux.intel.com>
Signed-off-by: Seppo Ingalsuo <seppo.ingalsuo@linux.intel.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.