[stable-v2.2] Tools: Topology1: Fix topologies build with new alsa-lib#10611
Open
kv2019i wants to merge 1 commit intothesofproject:stable-v2.2from
Open
[stable-v2.2] Tools: Topology1: Fix topologies build with new alsa-lib#10611kv2019i wants to merge 1 commit intothesofproject:stable-v2.2from
kv2019i wants to merge 1 commit intothesofproject:stable-v2.2from
Conversation
This patch fixes build error with alsa-lib commit 541427761292.
ALSA lib ops.c:47:(lookup_ops) [error.topology] wrong kcontrol
ops value string ''
It impacts build of sof-mt8195-mt6359-max98390-rt5682-rtnr.tplg
and sof-mt8195-mt6359-max98390-rt5682-google-aec-rtnr.tplg.
In the created .conf from m4 conversion, the value of put is
an empty string in SectionControlBytes.
# control uses bespoke driver get/put/info ID for ext ops
extops."extctl" {
thesofproject#258 binds the mixer control to bytes get handlers
get "258"
put ""
}
The use of m4 macro CONTROLBYTES_OPS() requires three parameters
while originally there was only two. All other usages of
CONTROLBYTES_EXTOPS() in SOF are with 258, 258 as 2nd and 3rd
parameters, so it is assumed it should be same for RTNR
controls also.
Signed-off-by: Seppo Ingalsuo <seppo.ingalsuo@linux.intel.com>
(cherry picked from commit 8f98a4e)
Signed-off-by: Kai Vehmanen <kai.vehmanen@linux.intel.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #10598
This patch fixes build error with alsa-lib commit 541427761292.
ALSA lib ops.c:47:(lookup_ops) [error.topology] wrong kcontrol ops value string ''
It impacts build of sof-mt8195-mt6359-max98390-rt5682-rtnr.tplg and sof-mt8195-mt6359-max98390-rt5682-google-aec-rtnr.tplg.
In the created .conf from m4 conversion, the value of put is an empty string in SectionControlBytes.
The use of m4 macro CONTROLBYTES_OPS() requires three parameters while originally there was only two. All other usages of CONTROLBYTES_EXTOPS() in SOF are with 258, 258 as 2nd and 3rd parameters, so it is assumed it should be same for RTNR controls also.
(cherry picked from commit 8f98a4e)