case-lib: refactor kernel logs collecting#1353
Open
ekurdybx wants to merge 1 commit intothesofproject:mainfrom
Open
case-lib: refactor kernel logs collecting#1353ekurdybx wants to merge 1 commit intothesofproject:mainfrom
ekurdybx wants to merge 1 commit intothesofproject:mainfrom
Conversation
8a6f5f4 to
5e67990
Compare
majunkier
requested changes
Mar 17, 2026
| finish_kmsg_collection() | ||
| { | ||
| dlogi "Finishing dmesg collection" | ||
| sudo pkill -9 journalctl |
Contributor
There was a problem hiding this comment.
There were already disscussion that pkill -9 should be solved different way. I know there are other files containing this solution but we could do it other way. Like :
Store PID when starting it:
journalctl_cmd ... -f >> dmesg.txt &
PID=$!
and stop only this
kill -TERM "$PID"
wait "$PID"
This avoid killing unrelated journalctl sessions from other jobs
Start collecting kernel logs in the beggining of the test and run collection in the background. Signed-off-by: Emilia Kurdybelska <emiliax.kurdybelska@intel.com>
7b06f8e to
a4a8d42
Compare
majunkier
reviewed
Mar 18, 2026
| # func_exit_handler() is in hijack.sh | ||
| trap 'func_exit_handler $?' EXIT | ||
| trap 'func_exit_handler $?' EXIT SIGTERM | ||
|
|
Contributor
There was a problem hiding this comment.
Moved checkpoint setup and kmsg collector to run after the EXIT SIGTERM trap. This ensures collector lifecycle is owned by main test flow and always cleaned up by exit handler.
setup_kernel_check_point
func_kmsg_collect
if [ "$SOF_TEST_PIPEWIRE" == true ]; then
func_lib_enable_pipewire
fi
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactor kernel messages collecting: