Skip to content

fix: don't modify input path if no mod used it #148

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
x87 wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: don't modify input path if no mod used it #148

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion src/plugins/gta3/std.asi/args_translator/xtranslator_path.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,7 +102,8 @@ inline void path_translator_base::CallInfo::TranslatePathForMainExecutable(const
// ...if not, try on the ASI paths or cleo paths
if(type == AR_PATH_INE && !IsPath(arg))
{
//
// Remember the original path so it can be restored if no mod wants it.
const T* const originalArg = arg;
bool bCheckModules = GetCurrentDir(arg, type, currdir, buffer);

// Check if currdir is alright
Expand Down Expand Up @@ -155,6 +156,10 @@ inline void path_translator_base::CallInfo::TranslatePathForMainExecutable(const
CheckASI();
CheckCleoScripts();
}

// Nothing wanted to translate this path, so put the original absolute path back.
// Leaving it relative makes the Win32 profile APIs resolve it against the Windows directory
if(!bSet) arg = originalArg;
}
}
}
Expand Down