Repository navigation
feat(schema): review_status + review_reason catalog columns - #67
Merged
Merged
Conversation
Two nullable string columns for the live-but-flagged review marker (Tim's ruling: keep live, flag, triage). review_status is 'under_review' when the dataset's candidate carries a substantive metadata-correctness review reason, else null; review_reason carries the reason text. Derived by the engine cut from the current candidate (a frozen rule), so clearing the reason drops the marker at the next cut. Bare needs_review flags and provenance-only notes get no marker.
Documentation build overview
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #67 +/- ##
=======================================
Coverage 94.67% 94.67%
=======================================
Files 22 22
Lines 2291 2291
=======================================
Hits 2169 2169
Misses 122 122 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two nullable string columns for the live-but-flagged review marker (keep-live/flag/triage).
review_status='under_review' when the dataset's candidate has a substantive metadata-correctness review reason (disease/tissue/organism/panel/TMA/relabel/…), else null;review_reasoncarries the reason text. The engine cut derives them from the current candidate via a frozen rule, so clearing the reason drops the marker at the next cut. Bareneeds_reviewflags and provenance-only notes get no marker. Pairs with the engine cut PR.