Repository navigation
schema(catalog): drop 5 unpopulated columns for the alpha - #63
Merged
Merged
Conversation
issue_url (points at the private curation repo), technology_version (no source; chemistry_version covers kit versioning), container_tag + sddb_version (build provenance, deferred to post-alpha) and thumbnail_url (cards now ship as sprite sheets, so a per-dataset URL would 404) were all 100% empty in the catalog. A clean schema beats empty columns for the alpha; container_tag/sddb_version return when provenance is wired. No client code or tests read them.
Documentation build overview
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #63 +/- ##
=======================================
Coverage 94.64% 94.64%
=======================================
Files 22 22
Lines 2278 2278
=======================================
Hits 2156 2156
Misses 122 122 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes five catalog columns that were 100% empty in catalog-2026-11-01, so the alpha ships a clean schema instead of dead columns (per the QC scorecard; Lead-approved).
issue_urltechnology_versionchemistry_versionalready carries the reagent-kit versioncontainer_tagsddb_versionthumbnail_urlthumbnails/<slug>_card.webpURL would 404 for all but the ~13 featured; the site resolves cards from sprites by slugsrc/sddb/_catalog_schema.pyand thedocs/design/SPEC.mdcolumn listing; reworded the comment that referencedtechnology_version.tests/test_catalog_schema.pypasses (41).thumbnail_urlfrom its field lists.uv lockafter merge, and remove the now-deadthumbnail_urlwiring from the cut.