preValidate method cannnot handle conditional validation.#213
Open
kochizufan wants to merge 1 commit intothedersen:masterfrom
Open
preValidate method cannnot handle conditional validation.#213kochizufan wants to merge 1 commit intothedersen:masterfrom
kochizufan wants to merge 1 commit intothedersen:masterfrom
Conversation
so make it possible.
Contributor
|
I had the same problem and can confirm that this patch works. I also created a similar solution but without introducing additional parameters to the method [f095b48] |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As README says in
https://github.com/thedersen/backbone.validation#do-you-support-conditional-validation
Conditional validation is allowed, but in preValidate method, it cannnot work.
So I make patch for it.