Repository navigation
Fix ev and event extensions on PHP 7.4 - #414
Merged
Merged
Conversation
Since install_all.sh fails on extension errors, every PHP 7.4 build fails: - ev: the latest PECL release (1.2.x) requires PHP 8.0. Pin ev-1.1.5 for PHP 7.4 only (the 8.0 link to core is unchanged). - event: libssl1.1 and the libevent packages were renamed on Ubuntu 24.04 (t64 transition). Only PHP 7.4 uses this extension. Also fix "docker --quiet pull" in the legacy v5 workflow: the flag was misplaced, so cached images were never pulled. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Every PHP 7.4 job of "Direct build v5 of legacy php" fails at the
install_all.shstep:These extensions were already broken, but the error was silently ignored. Since #411,
install_all.shusespipefailand fails the build when an extension cannot be installed.configure: error: need at least PHP 8.0.0).libssl1.1dependency does not exist on Ubuntu 24.04 (Unable to locateevent packages were also renamed (t64` transition).Changes
extensions/7.4/ev: replace the symlink tocore/evwith a real directory that pinsompatible with PHP 7.4. PHP 8.0 still usescore/ev`.extensions/core/event/install.sh: use the Ubuntu 24.04 package names (libevent-*-2.1-7t64,libssl3t64). Only PHP 7.4 uses this extension..github/workflows/legacy-v5.yml:docker --quiet pull→docker pull --quiet. The flag: --quiet), so cached images were never pulled. This did not fail the job because of|| echo ""`.Tests
docker buildx bake php74-cli: build OK, no failed extension.PHP_EXTENSION_EV=1 PHP_EXTENSION_EVENT=1 PHP_EXTENSION_SOCKETS=1: are loaded.