fix: fall back to other axis when main scroll direction is not scrollable#153
Open
es27 wants to merge 1 commit intotheKashey:masterfrom
Open
fix: fall back to other axis when main scroll direction is not scrollable#153es27 wants to merge 1 commit intotheKashey:masterfrom
es27 wants to merge 1 commit intotheKashey:masterfrom
Conversation
to other axis when main scroll direction is not scrollable When a touch gesture has a slightly larger horizontal delta than vertical (common during natural diagonal swipes), shouldCancelEvent determines moveDirection as 'h'. If no element in the hierarchy is horizontally scrollable, the event is immediately cancelled via preventDefault() — even though the user's intent is to scroll vertically. This change checks the perpendicular axis before blocking: if the other direction is scrollable, the gesture is allowed and the axis is switched accordingly. The event is only cancelled when neither axis can be scrolled. Fixes scroll blocking in modals/dialogs on mobile devices when the user's finger drifts slightly off the vertical axis during a swipe.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
On mobile devices, vertical scrolling inside modals/dialogs is blocked
when the user's finger moves with a slight horizontal offset during a swipe.
shouldCancelEventinSideEffect.tsxdeterminesmoveDirectionfromthe initial touch delta: