MathGame - #765
Conversation
🚀 Project Submitted!Thanks for submitting your project! I will review it soon. 📋 Please check the dashboard to make sure the project is marked as Pending. |
There was a problem hiding this comment.
Hi @dofelor , thanks for submitting! Unfortunately, the project has been submitted as a Git submodule rather than as the actual project files 🙁. This usually happens when your project is already a Git repository and you then move it into another repository. To fix this, you need to remove the .git folder from inside your project folder. The .git folder should still exist in the Academy repository, but not inside the project you are submitting. Once you've removed it, add, commit, and push the project files again so they appear normally in the pull request.
In the picture below you can see what was submitted in your project. You can click on "Files Changed" in your pull request to see what files were actually submitted.
|
Thanks for letting me know, I think I fixed it. |
|
@dofelor Project approved! 😄✅ It's a shame you didn't complete the challenges this time. 😟 It's always a good use of your time. But nothing stops you from revisiting the project later. 🥋And congratulations! You got your green belt!! 🟩🟩 Feedback and changes the calculation according to op. That's a good application of DRY. 🔍️ History should be part of the main menu as per requirements. At the moment history is only available after a game is finished. 🔍️Games should have a score as per requirements. 🔍The biggest opportunity is separation of responsibilities. Almost the entire application currently lives in Program.cs: menu handling, question generation, validation, history management, and game flow. For a beginner project that's acceptable, but I suggest extracting responsibilities into classes such as GameEngine, UserInput, and GameHistory. That would make Main() much easier to read and maintain. 🗺️ I noticed that you've completed Introduction to Object-Oriented Programming and Introduction to SQL . I'd highly recommend taking our LINQ Fundamentals course next. LINQ is one of the most important tools in modern C# and becoming comfortable with it will make your code much cleaner and more expressive. 👪Oh and if possible join our Discord Community and add your username to your profile so you can be part of the community as well. 😁 Overall great work!✋🏻Looking forward to seeing your next projects! |


No description provided.