Skip to content

MathGame - #765

Closed
dofelor wants to merge 3 commits into
the-csharp-academy:mainfrom
dofelor:main
Closed

MathGame#765
dofelor wants to merge 3 commits into
the-csharp-academy:mainfrom
dofelor:main

Conversation

@dofelor

@dofelor dofelor commented Sep 3, 2026

Copy link
Copy Markdown

No description provided.

@github-actions

github-actions Bot commented Sep 3, 2026

Copy link
Copy Markdown

🚀 Project Submitted!

Thanks for submitting your project! I will review it soon.

📋 Please check the dashboard to make sure the project is marked as Pending.

⚠️ If it's not marked as pending, submit it manually using the URL for this PR.

@TheCSharpAcademy TheCSharpAcademy left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @dofelor , thanks for submitting! Unfortunately, the project has been submitted as a Git submodule rather than as the actual project files 🙁. This usually happens when your project is already a Git repository and you then move it into another repository. To fix this, you need to remove the .git folder from inside your project folder. The .git folder should still exist in the Academy repository, but not inside the project you are submitting. Once you've removed it, add, commit, and push the project files again so they appear normally in the pull request.

In the picture below you can see what was submitted in your project. You can click on "Files Changed" in your pull request to see what files were actually submitted.

Image

@TheCSharpAcademy TheCSharpAcademy self-assigned this Sep 3, 2026
@dofelor

dofelor commented Sep 3, 2026

Copy link
Copy Markdown
Author

Thanks for letting me know, I think I fixed it.

@TheCSharpAcademy

Copy link
Copy Markdown
Collaborator

@dofelor Project approved! 😄✅ It's a shame you didn't complete the challenges this time. 😟 It's always a good use of your time. But nothing stops you from revisiting the project later.

🥋And congratulations! You got your green belt!! 🟩🟩

Feedback
✅ DRY / one method for the games: This challenge is essentially achieved in the question generation. Instead of creating four separate game-generation methods, you use:

static int[] ExampsAndAnswersCreate(string op, out string[] examples)

and changes the calculation according to op. That's a good application of DRY.

🔍️ History should be part of the main menu as per requirements. At the moment history is only available after a game is finished.
image

🔍️Games should have a score as per requirements.
image

🔍The biggest opportunity is separation of responsibilities. Almost the entire application currently lives in Program.cs: menu handling, question generation, validation, history management, and game flow. For a beginner project that's acceptable, but I suggest extracting responsibilities into classes such as GameEngine, UserInput, and GameHistory. That would make Main() much easier to read and maintain.

🗺️ I noticed that you've completed Introduction to Object-Oriented Programming and Introduction to SQL . I'd highly recommend taking our LINQ Fundamentals course next. LINQ is one of the most important tools in modern C# and becoming comfortable with it will make your code much cleaner and more expressive.

👪Oh and if possible join our Discord Community and add your username to your profile so you can be part of the community as well. 😁

Overall great work!✋🏻Looking forward to seeing your next projects!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants