Skip to content

submission for review - #764

Closed
lucidest wants to merge 2 commits into
the-csharp-academy:mainfrom
lucidest:main
Closed

submission for review#764
lucidest wants to merge 2 commits into
the-csharp-academy:mainfrom
lucidest:main

Conversation

@lucidest

@lucidest lucidest commented Sep 3, 2026

Copy link
Copy Markdown

No description provided.

@github-actions

github-actions Bot commented Sep 3, 2026

Copy link
Copy Markdown

🚀 Project Submitted!

Thanks for submitting your project! I will review it soon.

📋 Please check the dashboard to make sure the project is marked as Pending.

⚠️ If it's not marked as pending, submit it manually using the URL for this PR.

@TheCSharpAcademy TheCSharpAcademy left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lucidest Thanks for submitting! There is one requirement not being met. Could you please fix it before we can finish the review?

❌ A game currently contains only one question. Selecting Addition, Subtraction, Multiplication, or Division calls the corresponding method once and immediately returns to the menu. The requirement is that one game must have at least five questions.

💠You want a "game" to be a group of questions. So in the history you'd show something like: Date - Game Type - Score

@TheCSharpAcademy TheCSharpAcademy self-assigned this Sep 3, 2026
@lucidest

lucidest commented Sep 8, 2026

Copy link
Copy Markdown
Author

Thanks for taking a look, the changes have been made to meet the criteria you listed. Please let me know if you have any other questions or concerns!

@TheCSharpAcademy

Copy link
Copy Markdown
Collaborator

@lucidest Project approved! 😄✅ It's a shame you didn't complete the challenges this time. 😟 It's always a good use of your time. But nothing stops you from revisiting the project later.

🥋And congratulations! You got your green belt!! 🟩🟩

Feedback
🔍️ I highly recommend you learn about the DRY Principle (Don't Repeat Yourself) . There's a fair bit of repetition in the operations methods. You could have a single method for all operations, using variables for each operation.

🔍️These variables are fields:

public int addWinCount = 0;
public int subWinCount = 0;
public int mulWinCount = 0;
public int divWinConut = 0;

Suppose the player plays Addition twice. First game: 4 correct answers Then the second game has 3 correct answers Because addWinCount isn't reset, the second result will be recorded as 7 instead of 3.

🕵️‍♀️Also, have a look at our style guide since there are a few issues in your code. e.g. lots of unused usings, as per picture below. You can read our code conventions here🤓.

image

🗺️I noticed that you haven't completed any of our courses yet. I suggest you try our Intro to Object Oriented Programming course next. This will close gaps in your knowledge and give you more confidence about OOP

👪Oh and if possible join our Discord Community and add your username to your profile so you can be part of the community as well. 😁

Overall great work!✋🏻Looking forward to seeing your next projects!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants