Skip to content

My finished challenge - #762

Closed
lucascorreia-tech wants to merge 4 commits into
the-csharp-academy:mainfrom
lucascorreia-tech:main
Closed

My finished challenge#762
lucascorreia-tech wants to merge 4 commits into
the-csharp-academy:mainfrom
lucascorreia-tech:main

Conversation

@lucascorreia-tech

Copy link
Copy Markdown

No description provided.

@github-actions

Copy link
Copy Markdown

🚀 Project Submitted!

Thanks for submitting your project! I will review it soon.

📋 Please check the dashboard to make sure the project is marked as Pending.

⚠️ If it's not marked as pending, submit it manually using the URL for this PR.

@TheCSharpAcademy TheCSharpAcademy left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lucascorreia-tech Thanks for submitting your project. There are a couple of problems that you need to fix before we can review. First there's a bug where the app crashes when it tries to divide by zero:

Image

Additionally your app doesn't let the users choose the operation, which is a requirement of the project:

Image

Let me know if you need help, sou brasileiro tambem. 😁

@lucascorreia-tech lucascorreia-tech left a comment

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First of all, thank you for the reply. Because of that error, I reviewed the program's entire logic and refactored a large part of the code. Could you please take another look at it? VAMO Brazil! kkk

@TheCSharpAcademy

TheCSharpAcademy commented Sep 10, 2026

Copy link
Copy Markdown
Collaborator

@lucascorreia-tech Project approved! 😄✅ And well done for completing the challenges! I recommend you always do that, as it pushes you and makes you learn faster. Your project is clean, tidy, concise and to the point. And you're using only one method for all operations, great work! The project has an important bug but I'll let you fix it in your own time so you can progress in the roadmap.

🥋And congratulations! You got your green belt!! 🟩🟩

Feedback
🔍️There's a bug where anything that's not a division only has zeroes on both sides of the equation:
image

🔍️Naming could follow standard C# conventions more consistently. For example:

tempo_jogo
tempo_rodadas

would normally be:

tempoJogo
tempoRodadas

Also, Library doesn't describe what the class actually does. Something like MathGame, GameEngine, or GameService would communicate its responsibility better.

☕If you like our roadmap, please consider buying as a coffee. We appreciate your help 🙂

👪Oh and if possible join our Discord Community and add your username to your profile so you can be part of the community as well. 😁 And do you mind adding a country in your profile as well? The dashboard and leaderboard look neater when there's a flag. If you're not comfortable with that you can submit a random country.

Overall good work!✋🏻Looking forward to seeing your next projects!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants