My finished challenge - #762
Conversation
🚀 Project Submitted!Thanks for submitting your project! I will review it soon. 📋 Please check the dashboard to make sure the project is marked as Pending. |
TheCSharpAcademy
left a comment
There was a problem hiding this comment.
@lucascorreia-tech Thanks for submitting your project. There are a couple of problems that you need to fix before we can review. First there's a bug where the app crashes when it tries to divide by zero:
Additionally your app doesn't let the users choose the operation, which is a requirement of the project:
Let me know if you need help, sou brasileiro tambem. 😁
lucascorreia-tech
left a comment
There was a problem hiding this comment.
First of all, thank you for the reply. Because of that error, I reviewed the program's entire logic and refactored a large part of the code. Could you please take another look at it? VAMO Brazil! kkk
|
@lucascorreia-tech Project approved! 😄✅ And well done for completing the challenges! I recommend you always do that, as it pushes you and makes you learn faster. Your project is clean, tidy, concise and to the point. And you're using only one method for all operations, great work! The project has an important bug but I'll let you fix it in your own time so you can progress in the roadmap. 🥋And congratulations! You got your green belt!! 🟩🟩 Feedback 🔍️Naming could follow standard C# conventions more consistently. For example: would normally be: Also, Library doesn't describe what the class actually does. Something like MathGame, GameEngine, or GameService would communicate its responsibility better. ☕If you like our roadmap, please consider buying as a coffee. We appreciate your help 🙂 👪Oh and if possible join our Discord Community and add your username to your profile so you can be part of the community as well. 😁 And do you mind adding a country in your profile as well? The dashboard and leaderboard look neater when there's a flag. If you're not comfortable with that you can submit a random country. Overall good work!✋🏻Looking forward to seeing your next projects! |

No description provided.