Skip to content

Final Math Game implementation - #759

Closed
Brandonscodedata wants to merge 1 commit into
the-csharp-academy:mainfrom
Brandonscodedata:main
Closed

Final Math Game implementation#759
Brandonscodedata wants to merge 1 commit into
the-csharp-academy:mainfrom
Brandonscodedata:main

Conversation

@Brandonscodedata

Copy link
Copy Markdown

Hi! I know the feedback stated that a new Pull Request wasn't necessary. However, I had to fix an issue with my local Git tree and perform a force-push. Because the commit history was recreated, GitHub automatically closed the original PR and permanently disabled the 'Reopen' button. Opening this new PR was the only way to submit the requested changes (history menu and operator logic). Thanks for understanding!

@github-actions

Copy link
Copy Markdown

🚀 Project Submitted!

Thanks for submitting your project! I will review it soon.

📋 Please check the dashboard to make sure the project is marked as Pending.

⚠️ If it's not marked as pending, submit it manually using the URL for this PR.

@TheCSharpAcademy

TheCSharpAcademy commented Sep 9, 2026

Copy link
Copy Markdown
Collaborator

@Brandonscodedata Project approved! 😄✅ And well done for completing the some of the challenges! I recommend you always do that, as it pushes you and makes you learn faster.

🥋You still need to submit your Freecodecamp certificate before you start earning belts 😊

Feedback
🔍️ I'd recommend replacing structures such as:

List<int[]> gameList

with a small model, for example a GameResult custom type containing FirstNumber, SecondNumber, Operator, PlayerAnswer, and CorrectAnswer. game[3] doesn't tell the reader what the value represents, whereas game.CorrectAnswer does immediately. A list within a list gets messy and hard to maintain really quickly.

🔍️There are a few smaller cleanup opportunities too: using System.Diagnostics.Metrics; appears unused, the commented-out YesOrNo() method can be removed if it's no longer needed, and C# naming conventions would normally make GameRound camelCase (gameRound) because it's a private field.

🔍One small history issue is worth checking as well: choosing "d" clears gameList and operatorList, but not gameHistory. That means the summary history remains internally even though the UI reports that the game history was deleted. Clearing all three collections would make the behavior consistent.

🔍From the screenshot below we can see two problems. First, there's no history option in the menu. We can only see the history after the game is finished. It should be an option in the menu as per requirements. Additionally, notice that the console gets crowded and difficult to read very quickly. Consider clearing the console after each operation:

image

☕If you like our roadmap, please consider buying as a coffee. We appreciate your help 🙂

👪Oh and if possible join our Discord Community and add your username to your profile so you can be part of the community as well. 😁

Overall great work!✋🏻Looking forward to seeing your next projects!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants