Skip to content

Took a while to finish as a lost acess to proper use of my pc for a w… - #281

Closed
Hacker-735 wants to merge 2 commits into
the-csharp-academy:mainfrom
Hacker-735:main
Closed

Took a while to finish as a lost acess to proper use of my pc for a w…#281
Hacker-735 wants to merge 2 commits into
the-csharp-academy:mainfrom
Hacker-735:main

Conversation

@Hacker-735

Copy link
Copy Markdown

…hile

@github-actions

Copy link
Copy Markdown

🚀 Project Submitted!

Thanks for submitting your project! I will review it soon.

📋 Please check the dashboard to make sure the project is marked as Pending.

⚠️ If it's not marked as pending, submit it manually using the URL for this PR.

@TheCSharpAcademy

Copy link
Copy Markdown
Collaborator

@Hacker-735 Project approved! Apologies for the delay😄✅ It's a shame you didn't complete the challenges this time. 😟 It's always a good use of your time. But nothing stops you from revisiting the project later. Keep in mind that it's a very competitive environment out there in the software development industry. I highly recommend you do everything in your power to stand out from the competition. 👩‍🎤

🥋And congratulations! You got your Olive Green belt!! 🫒🫒

Feedback
🔍Since you asked for advice on UI stuff, what I recommend is that you let users choose records using arrows, with the help of Spectre Console. This way you don't need to ask for the input of an Id when deleting/updating, which will improve the user experience a lot 💪

🔍This is your 4th project now and I strongly recommend you always include Unit Tests from now on. Not only this is a must if you want to become a pro, but it changes the way you think about coding. The earlier you create this habit the better. We have an Intro tutorial to this Unit Testing here.💪

🔍There is one small bug worth fixing in Delete() and Update(). SelectSessionId() returns -1 when there are no sessions, but the calling operation continues afterward. Update() would then unnecessarily ask for a date and times before attempting WHERE id = -1. Consider returning early when the result is -1.

🗺️ I noticed that the only courses you've completed so far are Introduction to Object-Oriented Programming and Intro to SQL. I'd highly recommend taking our LINQ Fundamentals course next. LINQ is one of the most important tools in modern C# and becoming comfortable with it will make your code much cleaner and more expressive.

💁‍♂️If you have any questions, the best way to get help is in our Discord, in the #get-help-with-projects channel.

☕If you like our roadmap, please consider buying us a coffee. We appreciate your help 🙂

Overall good work!✋🏻Looking forward to seeing your next projects!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants