Challenges completed - #32
FeedMyData wants to merge 2 commits into
Conversation
🚀 Project Submitted!Thanks for submitting your project! I will review it soon. 📋 Please check the dashboard to make sure the project is marked as Pending. |
TheCSharpAcademy
left a comment
There was a problem hiding this comment.
@FeedMyData Thanks for submitting and apologies for the delay. Before we can review we need you to fix this issue:
Please rectify this and commit the changes when it's ready. No need to create a new pull-request😁
|
Thanks for the feedback and no need to apologize. You are helping us on our freetime, I am the one who should thank you and apologize for the slow answer (I was on vacation). |
|
@FeedMyData Project approved! 😄✅And congratulations for completing some of the challenges. That's how you improve!! 👏👏 And you even cleaned up the original code from the tutorial, which is quite messy. 💪 Feedback 🔍One edge case to revisit is history logging. DoOperation() adds an OperationLog even when an operation produces NaN, such as division by zero or the square root of a negative number. It would be cleaner to only add successful calculations to the history 🗺️ I noticed that the only course you've completed so far is Introduction to Object-Oriented Programming. I'd highly recommend taking our LINQ Fundamentals course next. LINQ is one of the most important tools in modern C# and becoming comfortable with it will make your code much cleaner and more expressive. ☕If you like our roadmap, please consider buying us a coffee. We appreciate your help 🙂 Overall good work!✋🏻Looking forward to seeing your next projects! |
(except the AI voices commands)