Skip to content

feat(lint): add CWE-tagged security rules to library source #598

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ofri-peretz wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat(lint): add CWE-tagged security rules to library source #598

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 17 additions & 0 deletions eslint.config.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,8 @@ import tseslint from 'typescript-eslint';
import angular from 'angular-eslint';
import jestDom from 'eslint-plugin-jest-dom';
import testingLibrary from 'eslint-plugin-testing-library';
import browserSecurity from 'eslint-plugin-browser-security';
import secureCoding from 'eslint-plugin-secure-coding';

export default tseslint.config(
{
Expand Down Expand Up @@ -46,6 +48,21 @@ export default tseslint.config(
'@angular-eslint/no-input-rename': 'off',
},
},
// Security rules, CWE- and CVSS-tagged. Scoped to library source: the spec
// files below are fixtures, and a fixture states the insecure thing on
// purpose. Measured against this repository before proposing: 0 findings.
{
files: ['**/*.ts'],
ignores: ['**/*.spec.ts'],
plugins: {
'browser-security': browserSecurity,
'secure-coding': secureCoding,
},
rules: {
...browserSecurity.configs.recommended.rules,
...secureCoding.configs.recommended.rules,
},
},
{
files: ['**/*.spec.ts'],
extends: [jestDom.configs['flat/recommended'], testingLibrary.configs['flat/angular']],
Expand Down
2 changes: 2 additions & 0 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,9 @@
"autoprefixer": "^10.4.21",
"cpy-cli": "^6.0.0",
"eslint": "^9.39.1",
"eslint-plugin-browser-security": "^2.0.5",
"eslint-plugin-jest-dom": "~5.10.1",
"eslint-plugin-secure-coding": "^5.1.2",
"eslint-plugin-testing-library": "~7.16.2",
"istanbul-lib-instrument": "^6.0.3",
"jasmine-core": "4.2.0",
Expand Down