Repository navigation
docs: document numeric option units and accept Date for logs since - #1627
Open
dieterstemmet wants to merge 1 commit into
Open
dieterstemmet wants to merge 1 commit into
dieterstemmet wants to merge 1 commit into
Conversation
JSDoc every size/duration field that was unit-ambiguous, and let
logs({ since }) take a Date as well as Unix seconds.
Fixes testcontainers#1542
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ResourcesQuota,HealthCheck, stop/restart/compose timeouts, wait-strategy timeouts, shared memory bytes).Dateas well as Unix seconds forlogs({ since }), converting viatoUnixSeconds.Date.now()are far in the future for Docker's second-based filter.Fixes #1542.
Test plan
npx vitest run packages/testcontainers/src/common/time.test.tsgeneric-container-logsDatesincecasewithResourcesQuota,withSharedMemorySize,logs, and health-check fieldsVerified
npx vitest run packages/testcontainers/src/common/time.test.ts: 16 passed--no-coverageon changed logic paths:toUnixSecondsCC 2 (under CRAP 10)--no-coverageonpackages/testcontainers/src/common/time.ts: 100% (3/3 killed, 0 survived)