Conversation
✅ Deploy Preview for testcontainers-node ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (15)
Included review availability: Your plan provides up to 8 included reviews per hour; 7 remain after this review. Summary by CodeRabbit
WalkthroughThe pull-policy API now supports ChangesNever-pull policy
Priority: ➖ Normal Estimated code review effort: 3 (Moderate) | ~25 minutes Change: Feature Sequence Diagram(s)sequenceDiagram
participant GenericContainer
participant resolvePullPolicy
participant DockerRuntimeClient
GenericContainer->>resolvePullPolicy: Resolve configured policy
resolvePullPolicy-->>GenericContainer: Return never
GenericContainer->>DockerRuntimeClient: Inspect local image
DockerRuntimeClient-->>GenericContainer: Return image status
Suggested reviewers: Merge Risk: ⚪ Minimal · up to The never-pull behavior is covered across container, Dockerfile-build, and Compose paths, with no actionable merge risk identified. 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
Full details: Docstring CoverageExplanation Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 3 functions across 10 files. (5 skipped: 5 unsupported.)
✨ Finishing Touches🧪 Generate unit tests (beta)
Warning Some tools did not complete. Review the errors below. 🔧 ESLint
packages/testcontainers/src/docker-compose-environment/docker-compose-environment.test.tsESLint skipped: missing config or dependency (missing-dependency). The ESLint configuration references a package that is not available in the sandbox. packages/testcontainers/src/docker-compose-environment/docker-compose-environment.tsESLint skipped: the matched ESLint configuration already failed (missing-dependency). packages/testcontainers/src/generic-container/generic-container-builder.tsESLint skipped: the matched ESLint configuration already failed (missing-dependency).
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. A rabbit guards the image gate Comment |
Implements the per-container pull policy discussed in #1455.
Adds
PullPolicy.neverPull()forGenericContainerand Docker Compose. Startup fails when a required image is missing locally. Existing pull policies retain their behavior.Compose uses
--pull never --no-build. Dockerfile builds reject this policy because the build API cannot guarantee that base images will not be pulled (docker/buildx#1889). Helper images such as Ryuk are unaffected.Validation
manifest unknownandaccess denied, respectively.CI: https://github.com/gologames/testcontainers-node/actions/runs/34852365970