Enforce verbatim response fetching in HttpWaitStrategy (#7326)#11937
Open
ivankrn wants to merge 1 commit into
Open
Enforce verbatim response fetching in HttpWaitStrategy (#7326)#11937ivankrn wants to merge 1 commit into
ivankrn wants to merge 1 commit into
Conversation
…s#7326) - Fix line ending truncation during response fetching - Fix unintended newline appending in the nc test container command Signed-off-by: Ivan Kropotin <102463202+ivankrn@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR replaces manual stream reading with a standard utility method to fix #7326, because Apache's
IOUtils.toString()preserves raw response formatting and line breaks unlike BufferedReader'sreadLine(), and also buffers the input internally, so there is no need to use manual buffering.The same approach has already been used in
ContainerDatabaseDriver,ScriptUtils, etc.