Refactor useCoordinateInfo Hook: Add WMTS Support, Optimize Layer Fetching, and Improve Performance#1001
Open
Refactor useCoordinateInfo Hook: Add WMTS Support, Optimize Layer Fetching, and Improve Performance#1001
Conversation
ahennr
force-pushed
the
feat/coordinate-info-abort-controller
branch
2 times, most recently
from
90bf754 to
2b932db
Compare
ahennr
force-pushed
the
feat/coordinate-info-abort-controller
branch
from
2b932db to
2ae3661
Compare
ahennr
force-pushed
the
feat/coordinate-info-abort-controller
branch
from
2ae3661 to
b68dcc7
Compare
ahennr
changed the title
ahennr
changed the title
KaiVolland
approved these changes
Feb 11, 2026
Comment on lines
6
to
+8
| import _isNil from 'lodash/isNil'; | ||
| import _isString from 'lodash/isString'; | ||
| import _uniqueId from 'lodash/uniqueId'; |
Member
There was a problem hiding this comment.
If you want to get rid of external dependencies you might want to have look at:
https://github.com/you-dont-need/You-Dont-Need-Lodash-Underscore
| }); | ||
|
|
||
| return relevantLayers; | ||
| }, [map, wfsMapLayers, wmtsMapLayers, wmsMapLayers]); |
Member
There was a problem hiding this comment.
Iterating over all layers (three times) for each variable seems inefficent to me. Maybe there is a way to do all this with one or at least less iterations.
15 tasks
Co-authored-by: Kai Volland <kaivolland@yahoo.de>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds WMTS (Web Map Tile Service) support to the
useCoordinateInfohook and refactors feature fetching logic for better performance and maintainability.Key Changes:
useMemohooks to memoize map properties and layer filteringAbortControllersupport to prevent memory leaks and race conditionsPlz review @terrestris/devs