Validate buffer index before accessing buffers vector#3535
Open
TristanInSec wants to merge 1 commit into
Open
Conversation
Check that the tensor buffer index is within the bounds of the model buffers vector before accessing it. The FlatBuffers Vector::operator[] does not perform bounds checking.
Contributor
|
This PR is being marked as stale due to inactivity. Remove the stale label or comment to prevent closure in 5 days. |
Author
|
This fix addresses a confirmed vulnerability. Still needed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Check that the tensor buffer index is within the bounds of the model buffers vector before accessing it, matching the validation already present in the compression code path.
BUG=b/general