Missing kTfLiteInt16 in ComparisonsPrepare#3391
Draft
veblush wants to merge 1 commit intotensorflow:mainfrom
Draft
Missing kTfLiteInt16 in ComparisonsPrepare#3391veblush wants to merge 1 commit intotensorflow:mainfrom
veblush wants to merge 1 commit intotensorflow:mainfrom
Conversation
ddavis-2015
reviewed
Feb 8, 2026
| TF_LITE_ENSURE(context, input2 != nullptr); | ||
|
|
||
| if (input1->type == kTfLiteInt8) { | ||
| if (input1->type == kTfLiteInt8 || input1->type == kTfLiteInt16) { |
Member
There was a problem hiding this comment.
@veblush should also have a check if the tensor is in fact quantized (unless the TfLite converter always produces quantized INT16???). I always assumed un-quantized INT16 was just as valid as unquantized INT32. Also add an is_quantized bool to the OpData?
Member
There was a problem hiding this comment.
@veblush The actual comparison Eval methods should also have INT16 support added. Not all LiteRT comparisons have INT16 support, and it is confusing how some LiteRT comparisons assume (or don't) that the INT16 inputs are not quantized.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BUG=n/a