Migrate to the Sass module system#7142
Open
jathak wants to merge 5 commits into
Open
Conversation
arcra
approved these changes
Jul 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation for features / changes
@importis deprecated in Sass and will be removed from the language in Dart Sass 3.0.0.Technical description of changes
@importrules in Sass code migrated to equivalent@userules using the Sass migrator, with namespaces added for any variables/mixins from dependencies. Calls to the globalmap-getandmap-mergefunctions have been replaced with themap.getandmap.mergefunctions in thesass:mapbuilt-in module, with the@userule added as necessary.Screenshots of UI changes (or N/A)
N/A, this is a no-op change.
Detailed steps to verify changes work correctly (as executed by you)
This is part of an internal LSC. I don't have the context of how this code is actually used or the bandwidth to set up a full development environment to test, but the migration is straightforward enough that I'm fairly confident your CI would catch anything if it broke. See the internal bug I'm filing for more information and alternatives if this isn't something you're comfortable merging at this time.
Alternate designs / implementations considered (or N/A)
N/A