Add support for binding to Unix sockets#7108
Open
robinkar wants to merge 1 commit into
Open
Conversation
Add the possibility of passing a path to a Unix socket as unix://<path> in the --host parameter to allow running TensorBoard securely on multi-user hosts.
|
Very much +1 on this, would be great to have this reviewed/merged |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #6057.
Adds the possibility of passing a path to a Unix socket as the host parameter,
--host unix:///path/to/tensorboard.sock, to bind TensorBoard to a Unix socket.Motivation for features / changes
This will allow running TensorBoard securely in multi-user hosts, e.g. on HPC clusters as in my case.
Technical description of changes
As Werkzeug supports listening on Unix sockets, this mostly affects the command-line argument handling to allow passing the Unix socket path to Werkzeug.
Detailed steps to verify changes work correctly
This is easiest to test using caddy:
TensorBoard should then print something like:
And http://localhost:8080 should work as expected.