Skip to content

Change default value for sorting dropdown in settings #7051

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
arcra merged 2 commits into from
Jan 22, 2026
+9 −1
Merged

Change default value for sorting dropdown in settings #7051

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a23e1a1
Change default value for sorting dropdown in settings. To have the to…
cdavalos7 Jan 21, 2026
70555ba
Unit test for new tooltip sorting default value
cdavalos7 Jan 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions tensorboard/webapp/metrics/metrics_integration_test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@ import {MetricsDashboardContainer} from './views/metrics_container';
describe('metrics integration test', () => {
const ByCss = {
SCALARS_SMOOTHING_INPUT: By.css('.scalars-smoothing input'),
TOOLTIP_SORT_DROPDOWN: By.css('.tooltip-sort tb-dropdown'),
};

beforeEach(() => {
Expand All @@ -44,6 +45,13 @@ describe('metrics integration test', () => {

const input = fixture.debugElement.query(ByCss.SCALARS_SMOOTHING_INPUT);
expect(input.nativeElement.value).toBe('0.6');

const tooltipSortDropdown = fixture.debugElement.query(
ByCss.TOOLTIP_SORT_DROPDOWN
);
expect(tooltipSortDropdown.componentInstance.value).toBe(
METRICS_SETTINGS_DEFAULT.tooltipSort
);
});

it('permits overriding default settings with DI', async () => {
Expand Down
2 changes: 1 addition & 1 deletion tensorboard/webapp/metrics/store/metrics_types.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -278,7 +278,7 @@ export interface State {

export const METRICS_SETTINGS_DEFAULT: MetricsSettings = {
cardMinWidth: null,
tooltipSort: TooltipSort.ALPHABETICAL,
tooltipSort: TooltipSort.NEAREST,
ignoreOutliers: true,
xAxisType: XAxisType.STEP,
hideEmptyCards: true,
Expand Down
Loading