Validate tensor ranks before padded batching - #4149
Open
x-Spartacus wants to merge 1 commit into
Open
x-Spartacus wants to merge 1 commit into
x-Spartacus wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change validates corresponding tensor ranks and schemas before calculating maximum dimensions or adding padding. The checks cover both the classic and TFRT batching paths, with an additional guard in
AddPadding.Previously, maximum dimensions were sized using the first task and then indexed using the ranks of later tasks. A mixed-rank batch could therefore index beyond the dimension vector.
Testing:
bazel test //tensorflow_serving/batching:batching_util_testbazel test //tensorflow_serving/batching:batching_session_testRegression coverage was also added for the TFRT path. That target could not be executed locally because existing external TFRT/XLA build rules fail first on undeclared includes.