This repository was archived by the owner on Mar 11, 2021. It is now read-only.
Open
Conversation
Contributor
Author
|
@amj want to test this for me :) |
amj
approved these changes
Sep 27, 2019
Contributor
amj
left a comment
amj
left a comment
There was a problem hiding this comment.
Is it possible to measure the effect of this change on our TPU steps/sec speed? It should of course not be expensive but it'd be nice to make sure we don't accidentally make it do something slow.
(LGTM anyway but i'd love to know the answer for how we'd test)
sethtroisi
force-pushed
the
more_metrics
branch
2 times, most recently
from
0e59c3c to
eb71831
Compare
sethtroisi
force-pushed
the
more_metrics
branch
from
eb71831 to
65f873a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Building on #896 in conjunction with #898