Add Danish translation - #912
Conversation
Signed-off-by: sorenkristensen80 <97378805+sorenkristensen80@users.noreply.github.com>
Signed-off-by: sorenkristensen80 <97378805+sorenkristensen80@users.noreply.github.com>
|
Thanks for this, and for doing it properly. I've been through both files and the translation itself is in good shape — key parity is exact on both catalogues, every placeholder and HTML tag matches One thing will stop it going in, though. The checks haven't run yet (first-time contributor, so I have to approve the run manually), but when they do, That test exists because Almost all of them are exactly the coincidences you describe in the PR body, and most are already whitelisted for other languages. So the fix is to add a "da.json": [
"activity.reason_bonus",
"badge.source_auto",
"badge.tier_bronze",
"badges.default_title",
"badges.label",
"child.bonus_label",
"child.bonus_tooltip",
"child.extra_submit",
"child.level_label",
"child.pause",
"child.start",
"common.design.cleanpro",
"common.design.console",
"common.design.playroom",
"dashboard.tab_rotation",
"overview.default_title",
"panel.badge_tab_title",
"panel.badge_table_badge",
"panel.badge_table_bonus",
"panel.child_avatar_label",
"panel.child_stat_level",
"panel.chore_image_upload",
"panel.entity_bonus",
"panel.health_count_badges",
"panel.nav_system",
"panel.notif_send_test",
"panel.reward_badge_jackpot",
"panel.settings_surprise_chance",
"panel.tab_badges",
"points_card.quick_label_add",
"points_card.quick_label_remove",
"points_display.editor.show_streak",
"points_display.editor.title_placeholder",
"points_display.streak",
"rewards.jackpot"
],Two other small things while you're in there:
On And yes please on the docs — that'd be a help. For what it's worth, I ran the full suite against your branch locally and got 2074 passed with that one failure and nothing else, so the baseline block plus those two edits should be all it needs. |
Translate Graphite to Grafit Signed-off-by: sorenkristensen80 <97378805+sorenkristensen80@users.noreply.github.com>
Add da to weekly target locale test Signed-off-by: sorenkristensen80 <97378805+sorenkristensen80@users.noreply.github.com>
Add da.json to English baseline Signed-off-by: sorenkristensen80 <97378805+sorenkristensen80@users.noreply.github.com>
Add da to locale lists in CONTRIBUTING Signed-off-by: sorenkristensen80 <97378805+sorenkristensen80@users.noreply.github.com>
|
Thanks for the thorough review! All done: Added the da.json block to locale_english_baseline.json The checks should now pass - happy to fix anything that still fails. Never tried this before, so please let me know if something's off :) Have a nice weekend - and thank you very much for Taskmate! // Søren |
CONTRIBUTING.md picked up Danish in #912 but the PR checklist did not.
Summary
Adds a full Danish (
da) translation for both catalogues:custom_components/taskmate/translations/da.json(config flow, selectors, services)custom_components/taskmate/www/locales/da.json(cards and admin panel)Only values are translated — all keys, placeholders and HTML tags are unchanged. Technical values users type into services (e.g.
morning,sticky,bronze) are deliberately left in English, as are Badge, Streak, Level/Lvl and XP, which is what Danish children and teens actually use.scripts/check_translations.pypasses — both catalogues matchen.jsonkey-for-key.The translation was drafted with AI assistance and then reviewed and corrected by me as a native Danish speaker.
If
dashould also be added to the locale lists inCONTRIBUTING.md, the PR template or the wiki's Supported Languages table, let me know and I'll include it.Related issue
N/A — new language, no existing issue. Motivation: Danish households using TaskMate currently fall back to English.
Type of change
How has this been tested?
Installed both files on my own Home Assistant instance with the user language set to Danish and restarted. The admin panel and cards show the Danish strings.
ruff check .locally (matches theRuffCI check)pytestlocally (matches theRun testsCI check)Checklist
manifest.jsonversionif this is a release-bound change(
de,fr,nb,nn,pt,pt-BR) in this same PR — not English-onlyREADME/ docs where relevantScreenshots / recordings