Skip to content

fix(wallet): replace retired credit funding guidance with MACH - #52

Open
parvahuja wants to merge 4 commits into
mainfrom
parv/retire-credit-funding-guidance
Open

parvahuja wants to merge 4 commits into
mainfrom
parv/retire-credit-funding-guidance

Conversation

@parvahuja

@parvahuja parvahuja commented Oct 14, 2026 •

Copy link
Copy Markdown
Member

Why

The wallet skill still tells agents to buy MPP Credits with fund --credits.

What

  • Explain that purchases are retired, direct new funding to MACH, and retain existing-credit balance/spending guidance.
  • Qualify MACH funding as mainnet-only and distinguish compatible charges from sessions.
  • Bump the wallet plugin to 0.1.1 and regenerate its platform manifests and goldens.

Validation: 39 tests, 2 live MCP checks, types/JSON/manifests, Claude validation, and GitHub skill publish dry-run pass. No release is published.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 14, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-14T18:41:59.143018Z 44b1427 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 44b14276a7

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread plugins/wallet/skills/wallet/SKILL.md Outdated
- Select `SERVICE_ID` from search results that best matches user intent. When multiple match: prefer best semantic fit, then endpoint fit, then pricing clarity, then first in list.
- **Anchor on `"$HOME/.tempo/bin/tempo" wallet -t services <SERVICE_ID>`** — it shows the exact URL, method, path, and pricing for every endpoint. Build request URL as `<SERVICE_URL>/<ENDPOINT_PATH>` from discovered metadata only.
- If service details include `supportsCredits: true`, MPP Credits may be used for one-time `tempo.charge` payments. Credits are separate from token balances; check them with `"$HOME/.tempo/bin/tempo" wallet -t whoami --credits` and buy them with `"$HOME/.tempo/bin/tempo" wallet fund --credits`.
- If service details include `supportsCredits: true`, existing MPP Credits may still be spent on eligible one-time `tempo.charge` payments. Check the separate balance with `"$HOME/.tempo/bin/tempo" wallet -t whoami --credits`. MPP Credits are deprecated and cannot be purchased; use `"$HOME/.tempo/bin/tempo" wallet fund --mach` to buy MACH instead. MACH purchases do not top up or convert legacy credits.

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Add MACH selection to the paid request flow

When a user with no legacy credits follows this guidance, they can purchase MACH but still cannot spend it using any execution command below: every template invokes tempo request without selecting MACH. The official CLI documentation states that MACH payments require tempo request --mach --max-spend ... and an exact challenge advertising machineTokenEnabled: true; supportsCredits: true only establishes eligibility for legacy credits. Consequently, the recommended purchase can leave the original request failing for insufficient token funds, so the skill should check MACH eligibility/balance and document the MACH-specific request invocation.

Useful? React with 👍 / 👎.

@claude claude Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I reviewed this PR and found no new bugs. A human look is still worth it: the change rewrites the funding guidance agents give users, and an earlier automated inline comment on SKILL.md line 71 has no visible resolution.

What was reviewed:

  • The 0.1.0 to 0.1.1 bump in manifest.config.ts. It matches all four generated wallet manifests and all five golden fixtures, Gemini included.
  • The SKILL.md rewrite. fund --credits purchase guidance is replaced with fund --mach, existing-credit balance and spending guidance is kept, and a new rule says MACH is mainnet-only and applies only when a one-time charge advertises machineTokenEnabled: true.
  • The troubleshooting table. The "Need to buy MPP Credits" row now points to MACH. The other credit rows still describe spending existing credits, which fits the new wording.
Extended reasoning...

The change is a version bump across manifest.config.ts, four generated plugin manifests and five golden fixtures, plus a 7-line edit to plugins/wallet/skills/wallet/SKILL.md. It touches no auth, crypto or data-handling code; the skill text only steers which payment commands an agent recommends to users. No CODEOWNERS file covers these paths. An automated reviewer's inline comment on SKILL.md:71 was followed by three more commits, but its resolution status is not visible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

1 participant