[DT-3584] Migrate Nexus form to Superforms with validation by andrewzamojc · Pull Request #3158 · temporalio/ui

andrewzamojc · 2026-02-12T19:53:44Z

Summary

Migrates the Nexus endpoint form to use Superforms with Zod validation, following the established Superforms pattern used throughout the application.

To test it yourself, run it locally and go to nexus. Try saving without filling out the form, or adding invalid data.

The form is also imported into cloud-ui. You can test that on here https://cloud-ui-git-test-ui-bef7a7fd.preview.thundergun.io/nexus

Before - on load before clicking submit

Before - fixing name

After

Clicked save without filling it out

invalid name

fixed it

here's the edit form, same validation but has a delete button

Changes

nexus-form.svelte: Refactored to use Superforms with proper validation
- Replaced manual state management with Superforms $form, $errors, and $enhance
- Added Zod schema validation for form fields
- Improved error handling and user feedback
nexus-create-endpoint.svelte & nexus-edit-endpoint.svelte: Updated to work with new Superforms pattern
Page components: Updated to pass data correctly to Superforms-enabled components

Benefits

Type-safe validation: Zod schema ensures runtime type safety
Consistent UX: Matches validation patterns used in other forms (capacity, groups, auth settings)
Better error handling: Clearer error messages and validation feedback
Maintainability: Follows established Superforms factory pattern

Testing

Tested Nexus endpoint creation flow
Tested Nexus endpoint edit flow
Verified validation errors display correctly
Confirmed form submission handling works as expected

vercel · 2026-02-12T19:53:49Z

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Actions	Updated (UTC)
holocene	Ready	Preview, Comment	Feb 23, 2026 6:24pm

- Replace writable store pattern with Superforms - Add Zod schema for form validation - Fix error display: only show after user interaction - Remove `endpointForm` store export - Use bind:this pattern to expose form methods - Update parent components to use new API - Ensure errors don't show on initial load or empty state

- Add optional chaining for formComponent in block - Add null checks for endpoint.id in update and delete handlers

This resolves the 'used before being assigned' error by acknowledging that formComponent is undefined until the component mounts and bind:this executes.

- Add toNexusEndpoint() utility to convert flat form data to nested API structure - Update create/edit pages to use transformation helper - Standardize nameHintText prop flow: base form has default, wrappers pass through - Remove inline transformations in favor of reusable utility This supports the Superforms migration by providing a shared transformation helper that both ui and cloud-ui can use to convert the new flat form structure to the nested NexusEndpoint structure required by the API.

- Change onSubmit prop type to return Promise<void> - Update onCreate and onUpdate wrapper callbacks to Promise<void> - Ensures SuperForms properly awaits async operations including navigation

- Matches pattern used in other forms (projects, etc) - Shows spinner during API call and navigation - Better visual feedback for users

- Add tainted state tracking from SuperForms - Button disabled when form hasn't been modified (edit forms only) - Prevents 'Nothing to change' API error - Matches pattern used in namespace settings forms - Button re-enables/disables as user makes/reverts changes

- Remove custom error state in favor of SuperForms message store - Add onError callback to display actual API error messages instead of generic fallbacks - Remove descriptionString from toNexusEndpoint helper (handled separately via encodePayloads) - Make allowedCallerNamespaces conditional to support OSS (omit when empty) - Await goto() calls to fix navigation timing and prevent loading state flash

temporal-cicd · 2026-02-19T18:08:44Z

	Warnings
⚠️	📊 Strict Mode: 1 error in 1 file (0.1% of 1114 total) src/lib/pages/nexus-form.svelte (1) L106:8: Type '{}' is not assignable to type 'string'.

Generated by 🚫 dangerJS against fca5668

The name field is disabled during editing, so the hint text is not needed.

rossnelson

Looks good overall — clean migration to Superforms. One thing to clean up before merge:

The onError handler in nexus-form.svelte has debug console.log statements that should be removed:

console.log('SuperForms error object:', error);
console.log('Error keys:', error && typeof error === 'object' ? Object.keys(error) : 'N/A');

Otherwise LGTM — approving.

temporal-cicd · 2026-02-23T18:24:19Z

+            ? errorObj.statusText
+            : undefined;
+        const body = errorObj.body;
+


⚠️ Type '{}' is not assignable to type 'string'.

Auto-generated version bump from 2.45.4 to 2.46.0 Bump type: minor Changes included: - [`1acf17c0`](1acf17c) docs: Add AUTHENTICATION.md referenced by README (#3157) - [`7d2368a2`](7d2368a) Corrected location of output directory (#3155) - [`1f2900c0`](1f2900c) [DT-3584] Migrate Nexus form to Superforms with validation (#3158) - [`f60fe1bf`](f60fe1b) feat(workflow): split Event History into Timeline and Event History tabs (#3109) - [`4801f8dc`](4801f8d) fix(workflow): remove extra vertical padding from history toolbar (#3179) - [`4ba52557`](4ba5255) Fix some minor bugs in the Standalone Activities UI (#3177)

Auto-generated version bump from 2.45.4 to 2.46.0 Bump type: minor Changes included: - [`1acf17c0`](1acf17c) docs: Add AUTHENTICATION.md referenced by README (#3157) - [`7d2368a2`](7d2368a) Corrected location of output directory (#3155) - [`1f2900c0`](1f2900c) [DT-3584] Migrate Nexus form to Superforms with validation (#3158) - [`f60fe1bf`](f60fe1b) feat(workflow): split Event History into Timeline and Event History tabs (#3109) - [`4801f8dc`](4801f8d) fix(workflow): remove extra vertical padding from history toolbar (#3179) - [`4ba52557`](4ba5255) Fix some minor bugs in the Standalone Activities UI (#3177) Co-authored-by: rossedfort <11775628+rossedfort@users.noreply.github.com>

andrewzamojc requested a review from a team as a code owner February 12, 2026 19:53

andrewzamojc requested review from GiantRobots and removed request for a team February 12, 2026 19:53

vercel Bot deployed to Preview February 12, 2026 19:54 View deployment

andrewzamojc marked this pull request as draft February 12, 2026 19:56

vercel Bot deployed to Preview February 17, 2026 16:17 View deployment

vercel Bot deployed to Preview February 17, 2026 16:38 View deployment

andrewzamojc added 4 commits February 17, 2026 14:02

fix: resolve TypeScript strict mode errors in nexus form

c6874c3

- Add optional chaining for formComponent in block - Add null checks for endpoint.id in update and delete handlers

fix: explicitly type formComponent as potentially undefined

a41edab

This resolves the 'used before being assigned' error by acknowledging that formComponent is undefined until the component mounts and bind:this executes.

make it work

f7d61ff

andrewzamojc force-pushed the DT-3584-nexus-form-superforms branch from d6cb621 to f7d61ff Compare February 17, 2026 19:03

vercel Bot deployed to Preview February 17, 2026 19:04 View deployment

andrewzamojc added 2 commits February 17, 2026 14:22

use snippets insetad of slot on nexus form

41ad88e

fix footer

d476e2f

vercel Bot deployed to Preview February 17, 2026 20:00 View deployment

make edit form hide name hint text since name field is disabled

4cdd9dd

vercel Bot deployed to Preview February 17, 2026 21:56 View deployment

remove unused prop

0ef1806

vercel Bot deployed to Preview February 17, 2026 22:28 View deployment

andrewzamojc marked this pull request as ready for review February 17, 2026 22:30

andrewzamojc added 4 commits February 18, 2026 14:19

Fix async callback types for Nexus form submissions

2814cd3

- Change onSubmit prop type to return Promise<void> - Update onCreate and onUpdate wrapper callbacks to Promise<void> - Ensures SuperForms properly awaits async operations including navigation

Add loading spinner to Nexus form submit button

ff6fcc3

- Matches pattern used in other forms (projects, etc) - Shows spinner during API call and navigation - Better visual feedback for users

andrewzamojc requested a review from Alex-Tideman as a code owner February 18, 2026 21:52

vercel Bot deployed to Preview February 18, 2026 21:53 View deployment

andrewzamojc added 2 commits February 18, 2026 21:58

rename toNexusEndpoint to getNexusEndpoint

5c9f5bc

vercel Bot deployed to Preview February 19, 2026 18:08 View deployment

vercel Bot deployed to Preview February 19, 2026 21:30 View deployment

fix an error

4dbfd63

andrewzamojc force-pushed the DT-3584-nexus-form-superforms branch from b077952 to 4dbfd63 Compare February 20, 2026 22:43

vercel Bot deployed to Preview February 20, 2026 22:44 View deployment

andrewzamojc added 3 commits February 23, 2026 10:23

Remove nameHintText from nexus edit form

cded962

The name field is disabled during editing, so the hint text is not needed.

tweak validation

bf83a76

actually removre nameHintText from ui on edit page

bef7a7f

vercel Bot deployed to Preview February 23, 2026 16:39 View deployment

rossnelson reviewed Feb 23, 2026

View reviewed changes

rossnelson approved these changes Feb 23, 2026

View reviewed changes

remove console log

fca5668

andrewzamojc enabled auto-merge (squash) February 23, 2026 18:23

vercel Bot deployed to Preview February 23, 2026 18:24 View deployment

temporal-cicd Bot reviewed Feb 23, 2026

View reviewed changes

andrewzamojc merged commit 1f2900c into main Feb 23, 2026
20 of 22 checks passed

andrewzamojc deleted the DT-3584-nexus-form-superforms branch February 23, 2026 19:17

temporal-cicd Bot mentioned this pull request Feb 24, 2026

chore: bump version to 2.46.0 #3180

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[DT-3584] Migrate Nexus form to Superforms with validation#3158

[DT-3584] Migrate Nexus form to Superforms with validation#3158
andrewzamojc merged 19 commits intomainfrom
DT-3584-nexus-form-superforms

andrewzamojc commented Feb 12, 2026 •

edited

Loading

Uh oh!

vercel Bot commented Feb 12, 2026 •

edited

Loading

Uh oh!

temporal-cicd Bot commented Feb 19, 2026 •

edited

Loading

Uh oh!

rossnelson left a comment

Uh oh!

temporal-cicd Bot Feb 23, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

andrewzamojc commented Feb 12, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Before - on load before clicking submit

Before - fixing name

After

Clicked save without filling it out

invalid name

fixed it

here's the edit form, same validation but has a delete button

Changes

Benefits

Testing

Uh oh!

vercel Bot commented Feb 12, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

temporal-cicd Bot commented Feb 19, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rossnelson left a comment

Choose a reason for hiding this comment

Uh oh!

temporal-cicd Bot Feb 23, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

andrewzamojc commented Feb 12, 2026 •

edited

Loading

vercel Bot commented Feb 12, 2026 •

edited

Loading

temporal-cicd Bot commented Feb 19, 2026 •

edited

Loading