Skip to content

Migrate signal_workflow_test to parallelsuite#9872

Open
long-nt-tran wants to merge 1 commit intotemporalio:mainfrom
long-nt-tran:signal-workflow-test-migration
Open

Migrate signal_workflow_test to parallelsuite#9872
long-nt-tran wants to merge 1 commit intotemporalio:mainfrom
long-nt-tran:signal-workflow-test-migration

Conversation

@long-nt-tran
Copy link
Copy Markdown
Contributor

@long-nt-tran long-nt-tran commented Apr 8, 2026

What changed?

As titled.

Changes are:

  • suite is now a self-referencing embedded parallelsuite.Suite[...]
  • each test gets their own env := testcore.NewEnv(s.T()). Note that tests that overrides env.OverrideDynamicConfig(dynamicconfig.EnableCrossNamespaceCommands, true) needs their own dedicated cluster in the new (parallel) suite because they override a global setting, so those ones creates the new testEnv with testcore.WithDedicatedCluster() option
  • s. -> env. for env-provided APIs (basically comms to test temporal cluster, etc...)
  • testcore.NewContext() -> env.Context() to use test-level ctx from the env we created

Why?

Migrating to a better framework and enabling parallel test runs.

How did you test it?

  • built
  • run locally and tested manually
  • covered by existing tests
  • added new unit test(s)
  • added new functional test(s)

Before

$ go test ./tests/ -run 'TestSignalWorkflowTestSuite' -count=1
ok      go.temporal.io/server/tests     59.685s

After

$ go test ./tests/ -run 'TestSignalWorkflowTestSuite' -count=1
ok      go.temporal.io/server/tests     11.557s

@long-nt-tran long-nt-tran marked this pull request as ready for review April 8, 2026 20:04
@long-nt-tran long-nt-tran requested review from a team as code owners April 8, 2026 20:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant