CHASM: improve support for implementing Terminate method#9351
Draft
yycptt wants to merge 2 commits intotemporalio:mainfrom
Draft
CHASM: improve support for implementing Terminate method#9351yycptt wants to merge 2 commits intotemporalio:mainfrom
yycptt wants to merge 2 commits intotemporalio:mainfrom
Conversation
yycptt
commented
Feb 19, 2026
| registry *Registry, | ||
| ) (bool, error) { | ||
| return validator.Validate( | ||
| augmentContextForComponent(ctx, component, registry), |
Member
Author
There was a problem hiding this comment.
we can do the same thing for registered tasks as well.
| // This is useful for propagating values needed for those processing logic but are not avaiable via the | ||
| // component's struct definition, such as configurations. | ||
| func WithContextValue( | ||
| keyVals map[any]any, |
Member
Author
There was a problem hiding this comment.
since the keyVals are the same across component instances, we don't really need to use context.Context.Value() to implement this which adds overhead. The chasmContext.Value() method can just check the registry for a key. The semantic will be different from context.Context though.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed?
Why?
How did you test it?