-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Add admin API and tdbg command to dump dynamic config values #8930
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add admin API and tdbg command to dump dynamic config values #8930
Conversation
This implements issue temporalio#421: adds GetDynamicConfig RPC to the admin service and a corresponding 'tdbg config list' command to dump all registered dynamic config settings along with their configured override values. Changes: - Extended GenericSetting interface with Description() and DefaultValue() methods - Added ListSettings() to registry for enumerating all registered settings - Added GetConfiguredValues() to Collection for retrieving configured overrides - Added proto definitions for GetDynamicConfig request/response - Implemented GetDynamicConfig in admin handler - Added tdbg config list command with key filtering support - Added tests for Description(), DefaultValue(), ListSettings(), GetConfiguredValues()
|
|
|
| return &adminservice.GetDynamicConfigResponse{Entries: entries}, nil | ||
| } | ||
|
|
||
| func precedenceToString(p dynamicconfig.Precedence) string { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do we need a type swtich?
| } | ||
| } | ||
|
|
||
| func constrainedValueToProto(cv dynamicconfig.ConstrainedValue) *adminservice.DynamicConfigValue { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
simplify?
|
will need to re-open. claude is preventing to license check from passing |
|
Closing in favor of existing PR. |
This implements issue #421: adds GetDynamicConfig RPC to the admin service and a corresponding 'tdbg config list' command to dump all registered dynamic config settings along with their configured override values.
Changes:
What changed?
Describe what has changed in this PR.
Why?
Tell your future self why have you made these changes.
How did you test it?
Potential risks
Any change is risky. Identify all risks you are aware of. If none, remove this section.