fix(frontend): return error when creating duplicate search attributes#8928
Closed
DEVMANISHOFFL wants to merge 1 commit into
Closed
fix(frontend): return error when creating duplicate search attributes#8928DEVMANISHOFFL wants to merge 1 commit into
DEVMANISHOFFL wants to merge 1 commit into
Conversation
|
|
Contributor
|
This looks like a duplicate PR of #8934 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed?
Updated AddSearchAttributes in operator_handler.go for both Elasticsearch and SQL paths, to return a serviceerror.NewAlreadyExists error immediately when a duplicate attribute is detected, inplace of just logging a warning and returning success....
Why?
Previously, the CLI would report "Search attributes have been added" even if the operation was skipped because the attribute existed. This silent failure caused confusion and made it difficult to detect configuration drift in CI/CD pipelines.
How did you test it?