Add CHASM Visibility component to CHASM Workflow#10434
Open
rodrigozhou wants to merge 1 commit into
Open
Conversation
rodrigozhou
force-pushed
the
rodrigozhou/chasm-wf-vis
branch
from
cbc6ddc to
fc07bc7
Compare
yycptt
reviewed
May 30, 2026
Member
yycptt
left a comment
yycptt
left a comment
There was a problem hiding this comment.
PR lgtm but want to understand a bit more on the migration plan. Looks like with this PR we are not doing dual write for custom SA/Memo yet, but workflow will generate both old visibility task and also chasm visibility task?
| } | ||
|
|
||
| if n.isActiveStateDirty { | ||
| if n.isActiveStateDirty || rootLifecycleChanged { |
Member
There was a problem hiding this comment.
nit: can you help add a comment saying the change is specifically for handling workflow case, otherwise when rootLifecycleChanged, isActiveStateDirty must be true.
| } | ||
|
|
||
| // CustomSearchAttributes returns the custom search attributes. | ||
| func (w *Workflow) CustomSearchAttributes(ctx chasm.Context) map[string]*commonpb.Payload { |
Member
There was a problem hiding this comment.
where/how will the following four methods be used?
|
|
||
| // SearchAttributes returns the predefined search attributes set in the underlying mutable state. | ||
| func (w *Workflow) SearchAttributes(ctx chasm.Context) []chasm.SearchAttributeKeyValue { | ||
| searchAttributes, err := w.GetPredefinedSearchAttributes() |
Member
There was a problem hiding this comment.
do we have to deep copy/clone the SAs here?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed?
Add CHASM Visibility component to CHASM Workflow
Why?
Support storing custom search attributes and memo in CHASM Workflow.
How did you test it?
Potential risks