Skip to content

Stabilize versioning3 test helpers#10424

Draft
stephanos wants to merge 5 commits into
mainfrom
stephanos/ver3-obvious-fixes
Draft

Stabilize versioning3 test helpers#10424
stephanos wants to merge 5 commits into
mainfrom
stephanos/ver3-obvious-fixes

Conversation

@stephanos
Copy link
Copy Markdown
Contributor

What changed

  • Close standalone versioning3 SDK clients when tests create them.
  • Validate speculative task history directly from the poll response.
  • Start the sticky completion poll before completing the blocking activity.
  • Run versioning3 worker registration pollers until registration is observed, then stop them cleanly.
  • Enable the worker service for versioning3 test envs so worker deployment registration APIs have the backing service available.

Verification

  • go test -tags test_dep ./tests -run '^TestVersioning3FunctionalSuite$/TestPinnedTask_NoProperPoller/NoTaskForwardNoPollForwardAllowSync$' -count=1 -timeout=10m\n- go test -tags test_dep ./tests -run '^TestVersioning3FunctionalSuite$/TestPinnedQuery_DrainedVersion_PollersAbsent/NoTaskForwardNoPollForwardAllowSync$' -count=1 -timeout=10m\n- go test -tags test_dep ./tests -run '^TestVersioning3FunctionalSuite$/TestPinnedTask_NoProperPoller/NoTaskForwardNoPollForwardAllowSync$|^TestVersioning3FunctionalSuite$/TestPinnedQuery_DrainedVersion_PollersAbsent/NoTaskForwardNoPollForwardAllowSync$' -count=1 -timeout=10m\n- make lint-code

@stephanos stephanos requested review from a team as code owners May 29, 2026 15:53

s.pollWftAndHandle(env, tv, sticky, nil,
finalWFTCompleted := make(chan struct{})
s.pollWftAndHandle(env, tv, sticky, finalWFTCompleted,
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Starting the final WFT poll before waiting for the activity completion removes an ordering race: under load, completing the activity can immediately unblock and schedule the WFT, and this test should already have the expected poller in place.

@stephanos stephanos marked this pull request as draft May 29, 2026 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant