WCP 3/X: Use correct BatchID in Timeout, Terminated and ContinueAsNew events#10418
Open
simvlad wants to merge 3 commits into
Open
WCP 3/X: Use correct BatchID in Timeout, Terminated and ContinueAsNew events#10418simvlad wants to merge 3 commits into
simvlad wants to merge 3 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed?
Change
HistoryBuilder.Add*Eventfor Terminate, Timeout and ContinueAsNew events to return batchID alongside the event, so that the callers that previously computed their own batchID just read it from there. SimplifiesTerminateWorkflowandTimeoutWorkflowas they no longer have to trackeventBatchFirstEventID.Stacked on #10412
Why?
Pushing batching knowledge to every caller was already error-prone, but after #10357 it is also wrong, since the event may fall on an unexpected batch.
How did you test it?
Potential risks
It's a bit hard to track why the code in TerminateWorkflow guesses the batch id, even though it could have get it from the EventStore, like this PR does. So the risk is that there is some case that I'm not taking into the account.