Add await attempt timeout#10416
Open
stephanos wants to merge 2 commits into
Open
Conversation
stephanos
force-pushed
the
stephanos/await-attempt-timeout
branch
from
e50e5de to
4fcfeab
Compare
stephanos
force-pushed
the
stephanos/await-attempt-timeout
branch
7 times, most recently
from
be3a125 to
0543253
Compare
stephanos
commented
May 28, 2026
|
|
||
| func newConfig() config { | ||
| return config{ | ||
| attemptTimeout: envDuration(attemptTimeoutEnvVar, 10*time.Second) * debug.TimeoutMultiplier, |
Contributor
Author
There was a problem hiding this comment.
intentionally omitting the ability to override it per test for now; will be in follow-up PR
stephanos
force-pushed
the
stephanos/await-attempt-timeout
branch
15 times, most recently
from
1a65b19 to
d5bfc5d
Compare
stephanos
force-pushed
the
stephanos/await-attempt-timeout
branch
from
d5bfc5d to
1a89d66
Compare
stephanos
commented
May 29, 2026
| tb.Fatalf("%s: condition not satisfied after %v (%d polls)", funcName, effectiveTimeout, polls) | ||
| message = fmt.Sprintf("%s (not satisfied after %v)", timeoutMsg, r.effectiveTimeout) | ||
| } | ||
| tb.Fatalf("%s: %s\ndetails:\n attempts = %d\n attempt timeouts = %d", |
Contributor
Author
There was a problem hiding this comment.
expose details to reason about failure (more to come here ...)
stephanos
commented
May 29, 2026
| cfg.pollInterval = pollInterval | ||
| cfg.timeoutMsg = timeoutMsg | ||
| return cfg | ||
| } |
Contributor
Author
There was a problem hiding this comment.
^ this will disappear once we migrated all the Await calls to a new option-based approach that uses reasonable defaults
stephanos
commented
May 29, 2026
| PR_BASE_COMMIT: ${{ github.event.pull_request.base.sha }} | ||
| DOCKER_COMPOSE_FILE: ./develop/github/docker-compose.yml | ||
| TEMPORAL_VERSION_CHECK_DISABLED: 1 | ||
| TEMPORAL_AWAIT_ATTEMPT_TIMEOUT: 15s |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed?
Added a timeout for an
Awaitattempt.Why?
Prevent an
Awaitattempt from being stuck for too long and consume the entire timeout.