Include in-memory (sync match) backlog in ApproximateBacklogCount#10396
Draft
sivagirish81 wants to merge 1 commit into
Draft
Include in-memory (sync match) backlog in ApproximateBacklogCount#10396sivagirish81 wants to merge 1 commit into
sivagirish81 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed?
Added in-memory sync-match backlog accounting for the new matcher so query and Nexus tasks waiting in taskPQ are included in task queue stats. Classic matcher is intentionally left unchanged.
Closes : #6760
Why?
Query and Nexus tasks can wait in memory while looking for a sync match and are not represented in DB backlog stats, so Describe could underreport backlog.
How did you test it?
Potential risks
The change is scoped to the new matcher and only counts non-DB-backlog in-memory tasks to avoid double counting.