Conversation
stephanos
force-pushed
the
stephanos/await-opts
branch
4 times, most recently
from
c536781 to
9f2e760
Compare
stephanos
commented
May 28, 2026
| deadline, ok := ctx.Deadline() | ||
| require.True(t, ok) | ||
| require.WithinDuration(t, time.Now().Add(time.Second), deadline, 50*time.Millisecond) | ||
| synctest.Test(t, func(t *testing.T) { |
Contributor
Author
There was a problem hiding this comment.
drive-by improvement
stephanos
force-pushed
the
stephanos/await-opts
branch
19 times, most recently
from
d4e098f to
64b8d40
Compare
stephanos
force-pushed
the
stephanos/await-opts
branch
from
64b8d40 to
465a9b6
Compare
stephanos
force-pushed
the
stephanos/testcontext-extend
branch
from
52653b9 to
2cffae6
Compare
stephanos
force-pushed
the
stephanos/await-opts
branch
from
465a9b6 to
38afbc7
Compare
stephanos
force-pushed
the
stephanos/testcontext-extend
branch
from
2cffae6 to
5fb966d
Compare
stephanos
force-pushed
the
stephanos/testcontext-extend
branch
from
5fb966d to
d311c81
Compare
stephanos
force-pushed
the
stephanos/await-opts
branch
from
38afbc7 to
d18b633
Compare
stephanos
force-pushed
the
stephanos/testcontext-extend
branch
from
d311c81 to
e49a9ee
Compare
stephanos
force-pushed
the
stephanos/await-opts
branch
2 times, most recently
from
4c87750 to
c243c77
Compare
stephanos
force-pushed
the
stephanos/testcontext-extend
branch
from
e49a9ee to
66e861b
Compare
stephanos
force-pushed
the
stephanos/await-opts
branch
from
c243c77 to
dd79d70
Compare
stephanos
force-pushed
the
stephanos/testcontext-extend
branch
from
66e861b to
58edaea
Compare
stephanos
force-pushed
the
stephanos/await-opts
branch
from
dd79d70 to
56f6c33
Compare
stephanos
force-pushed
the
stephanos/testcontext-extend
branch
2 times, most recently
from
0484cd8 to
d899349
Compare
stephanos
force-pushed
the
stephanos/await-opts
branch
from
56f6c33 to
0a70853
Compare
stephanos
force-pushed
the
stephanos/testcontext-extend
branch
from
d899349 to
5e71cbc
Compare
stephanos
force-pushed
the
stephanos/await-opts
branch
2 times, most recently
from
e30bb25 to
afb700a
Compare
stephanos
force-pushed
the
stephanos/testcontext-extend
branch
from
5e71cbc to
3639e99
Compare
stephanos
force-pushed
the
stephanos/await-opts
branch
from
afb700a to
17564db
Compare
stephanos
force-pushed
the
stephanos/testcontext-extend
branch
2 times, most recently
from
0bfea95 to
b44d21a
Compare
stephanos
force-pushed
the
stephanos/await-opts
branch
2 times, most recently
from
01f6d0f to
3fb9599
Compare
stephanos
force-pushed
the
stephanos/testcontext-extend
branch
from
b44d21a to
0e1279d
Compare
stephanos
force-pushed
the
stephanos/testcontext-extend
branch
from
0e1279d to
f08ca00
Compare
stephanos
force-pushed
the
stephanos/await-opts
branch
from
3fb9599 to
7fc3b8c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed?
Describe what has changed in this PR.
Why?
Tell your future self why have you made these changes.
How did you test it?
Potential risks
Any change is risky. Identify all risks you are aware of. If none, remove this section.