Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 4 additions & 8 deletions temporalio/sig/temporalio/client/connection.rbs
Original file line number Diff line number Diff line change
Expand Up @@ -97,13 +97,9 @@ module Temporalio

attr_reader options: Options

# TODO(cretz): Update when generated
# attr_reader workflow_service: WorkflowService
# attr_reader operator_service: OperatorService
# attr_reader cloud_service: CloudService
attr_reader workflow_service: untyped
attr_reader operator_service: untyped
attr_reader cloud_service: untyped
attr_reader workflow_service: WorkflowService
attr_reader operator_service: OperatorService
attr_reader cloud_service: CloudService

def initialize: (
target_host: String,
Expand Down Expand Up @@ -131,4 +127,4 @@ module Temporalio
private def new_core_client: -> Internal::Bridge::Client
end
end
end
end
1 change: 1 addition & 0 deletions temporalio/sig/temporalio/client/workflow_handle.rbs
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,7 @@ module Temporalio

def fetch_history: (
?event_filter_type: Integer,
?skip_archival: bool,
Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was just flat out missing

?rpc_options: RPCOptions?
) -> WorkflowHistory

Expand Down
4 changes: 4 additions & 0 deletions temporalio/sig/temporalio/converters.rbs
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
module Temporalio
module Converters
end
end
8 changes: 4 additions & 4 deletions temporalio/sig/temporalio/env_config.rbs
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ module Temporalio
) -> void

def to_h: -> Hash[Symbol, untyped]
def to_client_tls_options: -> (untyped | false)
def to_client_tls_options: -> (Client::Connection::TLSOptions | false)

private

Expand All @@ -34,7 +34,7 @@ module Temporalio
attr_reader namespace: String?
attr_reader api_key: String?
attr_reader tls: ClientConfigTLS?
attr_reader grpc_meta: Hash[untyped, untyped]
attr_reader grpc_meta: Hash[String, String]

def self.from_h: (Hash[untyped, untyped] hash) -> ClientConfigProfile

Expand All @@ -52,7 +52,7 @@ module Temporalio
?namespace: String?,
?api_key: String?,
?tls: ClientConfigTLS?,
?grpc_meta: Hash[untyped, untyped]
?grpc_meta: Hash[String, String]
) -> void

def to_h: -> Hash[Symbol, untyped]
Expand Down Expand Up @@ -83,4 +83,4 @@ module Temporalio
def to_h: -> Hash[String, Hash[Symbol, untyped]]
end
end
end
end
4 changes: 4 additions & 0 deletions temporalio/sig/temporalio/internal.rbs
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
module Temporalio
module Internal
end
end
8 changes: 8 additions & 0 deletions temporalio/sig/temporalio/internal/bridge/api.rbs
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
module Temporalio
module Internal
module Bridge
module Api
end
end
end
end
4 changes: 2 additions & 2 deletions temporalio/sig/temporalio/internal/bridge/client.rbs
Original file line number Diff line number Diff line change
Expand Up @@ -121,7 +121,7 @@ module Temporalio
class RPCFailure < Error
def code: -> Temporalio::Error::RPCError::Code::enum
def message: -> String
def details: -> String
def details: -> String?
Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We explicitly pass None across the boundary from the Rust side:

end

class CancellationToken
Expand All @@ -131,4 +131,4 @@ module Temporalio
end
end
end
end
end
4 changes: 2 additions & 2 deletions temporalio/sig/temporalio/workflow/info.rbs
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@ module Temporalio
workflow_id: String
) -> void

def to_h: -> Hash[Symbol, untyped]
def to_h: -> Hash[Symbol, String]
end

class RootInfo
Expand All @@ -72,7 +72,7 @@ module Temporalio
workflow_id: String
) -> void

def to_h: -> Hash[Symbol, untyped]
def to_h: -> Hash[Symbol, String]
end
end
end
Expand Down
2 changes: 1 addition & 1 deletion temporalio/sig/temporalio/workflow/update_info.rbs
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ module Temporalio
name: String
) -> void

def to_h: -> Hash[Symbol, untyped]
def to_h: -> Hash[Symbol, String]
end
end
end
Loading