-
Notifications
You must be signed in to change notification settings - Fork 30
π₯ Standalone Activities for Ruby #443
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
GregoryTravis
wants to merge
73
commits into
main
Choose a base branch
from
gmt/ruby-standalone-activities
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
73 commits
Select commit
Hold shift + click to select a range
b1c199a
Bump sdk-core to a22517e4 (0.4.0) (step 0)
GregoryTravis 30ae677
Merge branch 'main' into saa-yolo
GregoryTravis 411220b
Update ActivityIDReference to support standalone activities: new fielβ¦
GregoryTravis 0561236
wip (step 2)
GregoryTravis 8b3e08b
Merge branch 'main' into gmt/ruby-standalone-activities
GregoryTravis 79ec0e8
Merge branch 'main' into gmt/ruby-standalone-activities
GregoryTravis aea6eb6
Touch up docs.
GregoryTravis 029e387
Remove doc references to later steps
GregoryTravis 96bd69c
Interceptor path, Client, Info, async compltion (step 3)
GregoryTravis 6c463ff
More tests
GregoryTravis 785f99a
Make result polling test activity run long enough to actually exercisβ¦
GregoryTravis ff172a9
Document that attempt ordering starts at 1.
GregoryTravis 3a76877
Workflow interceptor ordering tests
GregoryTravis 4978bde
Amend comment
GregoryTravis a134674
Simplify activity specification dispatch
GregoryTravis 7e679eb
Complete docs for execute_activity
GregoryTravis 2432134
Default ActivityIDConflictPolicy to UNSPECIFIED.
GregoryTravis 85ae01f
Default back to ActivityIDConflictPolicy::FAIL
GregoryTravis 54ea93e
Add result to example
GregoryTravis 4430429
Fix count assertions in tests
GregoryTravis b1540a0
Check result in test_get_handle_with_nil_run_id
GregoryTravis 3aefd55
Update name of test_activity_handle_describe_terminate_smoke
GregoryTravis 346da6d
In test_describe_canceled_reason_after_cancel, check the status and tβ¦
GregoryTravis 553ad50
Additional hint tests
GregoryTravis 404674a
Test type hint override in activity_handle constructor.
GregoryTravis 1823197
Update docstring on ActivitHandle.result
GregoryTravis 35931d7
Test for multiple long-poll timeouts
GregoryTravis b7bc32b
Remove presence check for proto .run_id.
GregoryTravis b8b960d
Use nil for missing reason
GregoryTravis c677537
Clarify doc on _type_and_hints_from_parameter
GregoryTravis 9de8b3d
Merge branch 'main' into gmt/ruby-standalone-activities
GregoryTravis b496fb8
"or" clarification in cancel/terminate example
GregoryTravis fc15980
CHANGELOG
GregoryTravis 3887a4e
.gitattributes with union=merge for CHANGELOG
GregoryTravis cdd4ee9
Lint
GregoryTravis cf6ae35
Regenerate proto classes
GregoryTravis ccbd9ef
yard fix
GregoryTravis 35f774b
Merge branch 'main' into gmt/ruby-standalone-activities
GregoryTravis e710c58
Potential fix for pull request finding
GregoryTravis 72f4233
Fix missing-fields comment
GregoryTravis 5046a13
nil instead of Nil
GregoryTravis 4a110b2
_activity_id_reference_request_fields
GregoryTravis 50834b1
workflow namespace is optional
GregoryTravis f93c2f4
Missing namespace falls back to client namespace
GregoryTravis b09b9c1
review
GregoryTravis 43b31a8
review
GregoryTravis 6fcdfc9
Add test_cancel_activity_interceptor_called.
GregoryTravis e64fb21
Test for list activities pagination
GregoryTravis c6e0f43
workflow_namespace is nil for SAA
GregoryTravis 5ba0ea7
review
GregoryTravis 2f948d4
Update temporalio/lib/temporalio/client/activity_execution.rb
GregoryTravis 21868fe
Merge branch 'gmt/ruby-standalone-activities' of https://github.com/tβ¦
GregoryTravis 8a49b7d
Update temporalio/lib/temporalio/client/activity_execution.rb
GregoryTravis 06db942
Merge branch 'gmt/ruby-standalone-activities' of https://github.com/tβ¦
GregoryTravis 2a28187
review
GregoryTravis 56be55f
review
GregoryTravis 143f159
PendingActivityState constant module
GregoryTravis c6357a8
review
GregoryTravis caefb23
Merge branch 'main' into gmt/ruby-standalone-activities
GregoryTravis 2085f2e
Revert sdk-core/rust version bump, no longer needed.
GregoryTravis 37c5183
SAA server flags no longer needed for tests.
GregoryTravis 5c6c296
Don't expose state transition count
GregoryTravis 392bef4
Markdown quoting, not rdoc.
GregoryTravis 7bd3fbd
Update temporalio/lib/temporalio/client/activity_handle.rb
GregoryTravis 0a316a3
Merge branch 'gmt/ruby-standalone-activities' of https://github.com/tβ¦
GregoryTravis 6c094d7
review
GregoryTravis ba57829
Mention ID reuse and conflict policy.
GregoryTravis 6dd9732
Restore activity pause flag
GregoryTravis 6ac8a9e
Update temporalio/lib/temporalio/common_enums.rb
GregoryTravis 9d9d35f
Fix reuse policy docs.
GregoryTravis 57a92c4
Reformat CHANGELOG to standard format, remove code snippet.
GregoryTravis ac8d528
Input validation for start_activity
GregoryTravis e325de4
RBS types for protobufs
GregoryTravis File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| CHANGELOG.md merge=union |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,31 @@ | ||
| # Changelog | ||
|
|
||
| ## [Unreleased] | ||
|
|
||
| ### Breaking Changes | ||
|
|
||
| #### `Activity::Info` workflow fields are now nullable | ||
|
|
||
| With the introduction of Standalone Activities (see below), an activity is no longer guaranteed to | ||
| have been scheduled by a workflow. `Activity::Info#workflow_id`, `#workflow_run_id`, | ||
| `#workflow_type`, and `#workflow_namespace` are now nullable β they return `nil` when the activity | ||
| was started via `Client#start_activity` rather than from a workflow. A new `Activity::Info#namespace` | ||
| accessor is always set (falling back to the client's namespace for standalone activities) and is | ||
| the recommended replacement for the deprecated `#workflow_namespace`. | ||
|
|
||
| Existing workflow-only code paths are unaffected at runtime. The recommended migration is to call | ||
| `Activity::Info#in_workflow?` and branch on the result. | ||
|
|
||
| ### Added | ||
|
|
||
| #### Standalone Activities | ||
|
|
||
| Activities can now be started directly from a client, independently of any workflow. `Client#start_activity` | ||
| and `Client#execute_activity` schedule a standalone activity execution by ID and task queue, accepting the | ||
| same `Activity::Definition` classes (or by-name strings/symbols) used in workflow-scheduled activities. | ||
| `Client::ActivityHandle` provides `#result`, `#describe`, `#cancel`, and `#terminate`; `Client#list_activities` | ||
| and `Client#count_activities` provide visibility-backed queries; and `Client#async_activity_handle` now | ||
| accepts a standalone-form `ActivityIDReference` (constructed via `ActivityIDReference.for_standalone`) for | ||
| async completion. | ||
|
|
||
| See https://docs.temporal.io/standalone-activity for the cross-SDK feature overview. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.