Repository navigation
Update system nexus generation to include notification service - #1925
Merged
Merged
Conversation
VegetarianOrc
added this pull request to stack #1927
October 5, 2026 18:02
VegetarianOrc
force-pushed
the
amazzeo/nexus-handler-callbacks
branch
3 times, most recently
from
October 5, 2026 18:43
d9adf4b to
e81a1d8
Compare
tconley1428
reviewed
Oct 5, 2026
tconley1428
reviewed
Oct 5, 2026
| source.write_text(rewritten) | ||
|
|
||
|
|
||
| def workflow_exports() -> list[str]: |
Contributor
There was a problem hiding this comment.
I assume we need something like this for notification service too.
tconley1428
reviewed
Oct 5, 2026
| staged_notification / "_support", | ||
| ] | ||
| staged_support = staged_workflow.parent / "_support" | ||
| merge_support_trees(staged_support_dirs, staged_support) |
Contributor
There was a problem hiding this comment.
I don't think we should be merging the independent support directories into one. The support files should live with the service they are defined by.
VegetarianOrc
force-pushed
the
amazzeo/nexus-handler-callbacks
branch
from
October 13, 2026 18:11
e81a1d8 to
8387538
Compare
VegetarianOrc
force-pushed
the
amazzeo/nexus-handler-callbacks
branch
from
October 13, 2026 18:12
8387538 to
71487e0
Compare
VegetarianOrc
marked this pull request as ready for review
October 13, 2026 18:47
VegetarianOrc
marked this pull request as draft
October 13, 2026 18:51
tconley1428
reviewed
Oct 13, 2026
| @@ -0,0 +1 @@ | |||
| Add notification service models in `temporalio.nexus.notifications`. | |||
Contributor
There was a problem hiding this comment.
Might want to mention how they aren't actually used for anything yet.
VegetarianOrc
marked this pull request as ready for review
October 13, 2026 22:10
tconley1428
approved these changes
Oct 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was changed
temporalio.nexus.notificationspackage fromnotification-service.wit.temporalio/nexus/_support.workflow_servicepackage is generated again with the new version.Why
Nexus handler callbacks need typed Python models for the
OnCompleterequest and response of the notification service. This PR uses the NexGen pipeline that already generates the workflow service system API to generate these models. The support module moves to a shared location so that the two generated packages can use it. The handler callback implementation is in the stacked PR (#1926).Checklist