Skip to content

[SDK Sentinel] Stabilize sticky cache metrics test #3037

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sdk-sentinel-bot wants to merge 1 commit into
base: main
Choose a base branch
from
+21 −4
Open

[SDK Sentinel] Stabilize sticky cache metrics test #3037

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 21 additions & 4 deletions temporal-sdk/src/test/java/io/temporal/workflow/MetricsTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -488,7 +488,7 @@ public void testStickyCacheSize() throws InterruptedException, ExecutionExceptio
setUp(WorkerFactoryOptions.getDefaultInstance());

Worker worker = testEnvironment.newWorker(TASK_QUEUE);
worker.registerWorkflowImplementationTypes(TestWorkflowWithSleep.class);
worker.registerWorkflowImplementationTypes(TestWorkflowWithSignal.class);
testEnvironment.start();

Thread.sleep(REPORTING_FLUSH_TIME);
Expand All @@ -500,14 +500,16 @@ public void testStickyCacheSize() throws InterruptedException, ExecutionExceptio
.setWorkflowRunTimeout(Duration.ofSeconds(7000))
.setTaskQueue(TASK_QUEUE)
.build();
NoArgsWorkflow workflow = workflowClient.newWorkflowStub(NoArgsWorkflow.class, options);
CacheMetricsWorkflow workflow =
workflowClient.newWorkflowStub(CacheMetricsWorkflow.class, options);
CompletableFuture<Void> wfFuture = WorkflowClient.execute(workflow::execute);
SDKTestWorkflowRule.waitForOKQuery(WorkflowStub.fromTyped(workflow));

Thread.sleep(REPORTING_FLUSH_TIME);
reporter.assertGauge(STICKY_CACHE_SIZE, TAGS_NAMESPACE, 1);
reporter.assertGauge(WORKFLOW_ACTIVE_THREAD_COUNT, TAGS_NAMESPACE, val -> val == 1 || val == 2);

workflow.complete();
wfFuture.get();

Thread.sleep(REPORTING_FLUSH_TIME);
Expand Down Expand Up @@ -645,11 +647,26 @@ public String execute() {
}
}

public static class TestWorkflowWithSleep implements NoArgsWorkflow {
@WorkflowInterface
public interface CacheMetricsWorkflow {
@WorkflowMethod
void execute();

@SignalMethod
void complete();
}

public static class TestWorkflowWithSignal implements CacheMetricsWorkflow {
private boolean complete;

@Override
public void execute() {
Workflow.sleep(5000);
Workflow.await(() -> complete);
}

@Override
public void complete() {
complete = true;
}
}

Expand Down